Skip to content

Commit 91d26b5

Browse files
committed
style: consistent capitalization in error and warning identifiers
1 parent f76c55c commit 91d26b5

File tree

17 files changed

+28
-23
lines changed

17 files changed

+28
-23
lines changed

app/DataVisualization.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ function selectMission(app, mission)
126126
mission = app.SelectMissionDialog.waitForSelection();
127127

128128
if app.SelectMissionDialog.Aborted
129-
error("mag:app:abort", "User aborted.");
129+
error("mag:app:Abort", "User aborted.");
130130
else
131131
app.SelectMissionDialog.delete();
132132
end
@@ -144,7 +144,7 @@ function selectMission(app, mission)
144144
case mag.meta.Mission.IMAP
145145
app.Provider = mag.app.imap.Provider();
146146
otherwise
147-
error("mag:app:unsupportedMission", "%s mission not supported.", app.Mission.DisplayName);
147+
error("mag:app:UnsupportedMission", "%s mission not supported.", app.Mission.DisplayName);
148148
end
149149

150150
% Set managers.

app/core/+mag/+app/+control/SignalAnalyzer.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ function instantiate(this, parent)
7070
data = results.(selectedInput);
7171

7272
if ~data.isPlottable()
73-
error("mag:app:emptySignal", "Not enough data for plotting ""%s"".", selectedInput);
73+
error("mag:app:EmptySignal", "Not enough data for plotting ""%s"".", selectedInput);
7474
end
7575

7676
selectedData = timetable(data.Time - data.Time(1), data.(selectedSignal), VariableNames = selectedInput + "_" + selectedSignal);

app/core/+mag/+app/+control/WaveletAnalyzer.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ function instantiate(this, parent)
8585
data = results.(selectedInput);
8686

8787
if ~data.isPlottable()
88-
error("mag:app:emptySignal", "Not enough data for plotting ""%s"".", selectedInput);
88+
error("mag:app:EmptySignal", "Not enough data for plotting ""%s"".", selectedInput);
8989
end
9090

9191
propertyName = selectedInput + "_" + selectedSignal;

app/core/+mag/+app/+internal/removeNonFiniteData.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
if any(locNonFinite, "all")
1515

16-
warning("mag:app:nonFiniteData", "Removing non-finite data.");
16+
warning("mag:app:NonFiniteData", "Removing non-finite data.");
1717
data(any(locNonFinite, 2), :) = [];
1818
end
1919
end

app/core/+mag/+app/+internal/resampleIrregularData.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
dt = diff(data.Properties.RowTimes);
1515
frequencies = 1 ./ seconds(dt);
1616

17-
warning("mag:app:nonFiniteData", "Resampling data as not uniformely sampled (%.3f ± %.3g Hz).", mode(frequencies), std(frequencies, 0, "omitmissing"));
17+
warning("mag:app:NonFiniteData", "Resampling data as not uniformly sampled (%.3f ± %.3g Hz).", mode(frequencies), std(frequencies, 0, "omitmissing"));
1818

1919
data = resample(data);
2020
end

app/core/+mag/+app/+manage/VisualizationManager.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ function reset(this)
6060
% VISUALIZE Visualize analysis using selected view.
6161

6262
if isempty(this.SelectedControl)
63-
error("mag:app:noViewSelected", "No view selected.");
63+
error("mag:app:NoViewSelected", "No view selected.");
6464
end
6565

6666
command = this.SelectedControl.getVisualizeCommand(analysis.Results);

app/mission/bart/+mag/+app/+bart/AnalysisManager.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,9 +91,9 @@ function reset(this)
9191
location = this.LocationEditField.Value;
9292

9393
if isempty(location)
94-
error("mag:app:emptyLocation", "Location is empty.");
94+
error("mag:app:EmptyLocation", "Location is empty.");
9595
elseif ~isfolder(location)
96-
error("mag:app:nonexistentLocation", "Location ""%s"" does not exist.", location);
96+
error("mag:app:NonexistentLocation", "Location ""%s"" does not exist.", location);
9797
end
9898

9999
options = {"Location", this.LocationEditField.Value, ...

app/mission/hs/+mag/+app/+hs/AnalysisManager.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,9 @@ function reset(this)
9999
location = this.LocationEditField.Value;
100100

101101
if isempty(location)
102-
error("mag:app:emptyLocation", "Location is empty.");
102+
error("mag:app:EmptyLocation", "Location is empty.");
103103
elseif ~isfolder(location)
104-
error("mag:app:nonexistentLocation", "Location ""%s"" does not exist.", location);
104+
error("mag:app:NonexistentLocation", "Location ""%s"" does not exist.", location);
105105
end
106106

107107
% Retrieve data file patterns.

app/mission/imap/+mag/+app/+imap/+control/CPT.m

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ function validatePattern(~, changingData)
9999
pattern = asManyOfPattern(digitsPattern() + optionalPattern(characterListPattern(",") + whitespacePattern()));
100100

101101
if ~matches(value, pattern)
102-
error("mag:app:invalidPattern", "Value must match the pattern ""1, 2, 3"".");
102+
error("mag:app:InvalidPattern", "Value must match the pattern ""1, 2, 3"".");
103103
end
104104
end
105105
end
@@ -115,5 +115,3 @@ function validatePattern(~, changingData)
115115
end
116116
end
117117
end
118-
119-

app/mission/imap/+mag/+app/+imap/AnalysisManager.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,9 +128,9 @@ function reset(this)
128128
location = this.LocationEditField.Value;
129129

130130
if isempty(location)
131-
error("mag:app:emptyLocation", "Location is empty.");
131+
error("mag:app:EmptyLocation", "Location is empty.");
132132
elseif ~isfolder(location)
133-
error("mag:app:nonexistentLocation", "Location ""%s"" does not exist.", location);
133+
error("mag:app:NonexistentLocation", "Location ""%s"" does not exist.", location);
134134
end
135135

136136
% Retrieve data file patterns.

app/mission/imap/+mag/+app/+imap/VisualizationManager.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
function figures = visualize(this, analysis)
2525

2626
if isempty(this.SelectedControl)
27-
error("mag:app:noViewSelected", "No view selected.");
27+
error("mag:app:NoViewSelected", "No view selected.");
2828
end
2929

3030
if isa(this.SelectedControl, "mag.app.imap.control.AT") || isa(this.SelectedControl, "mag.app.imap.control.CPT")

buildfile.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
if isMATLABReleaseOlderThan("R2025a")
77

8-
warning("mag:buildtool:path", "MATLAB release ""%s"" not supported for development purposes. " + ...
8+
warning("mag:buildtool:Path", "MATLAB release ""%s"" not supported for development purposes. " + ...
99
"Adding all folders to the path for testing purposes.", matlabRelease().Release);
1010

1111
% Brute-force add all folders to the path.

src/utility/+mag/+time/decodeDate.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,5 @@
3232
end
3333
end
3434

35-
error("mag:time:parseError", "Unable to parse date '%s' using the formats %s.", date, join(compose("'%s'", formats), ", "));
35+
error("mag:time:ParseError", "Unable to parse date '%s' using the formats %s.", date, join(compose("'%s'", formats), ", "));
3636
end

tests/tool/+mag/+test/runTests.m

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
function testResults = runTests()
2+
3+
root = mfilename("fullpath");
4+
root = fullfile(fileparts(root), "..", "..", "..");
5+
6+
testResults = runtests(root, IncludeSubfolders = true, ReportCoverageFor = ["app", "src"]);
7+
end

tests/unit/app/tSignalAnalyzer.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ function getVisualizeCommand_nonFiniteData(testCase)
7575
expectedData = expectedData([1, 3:4, 6:end], :);
7676

7777
% Exercise.
78-
command = testCase.verifyWarning(@() signalAnalyzer.getVisualizeCommand(results), "mag:app:nonFiniteData", ...
78+
command = testCase.verifyWarning(@() signalAnalyzer.getVisualizeCommand(results), "mag:app:NonFiniteData", ...
7979
"Warning should be issued when removing non-finite data.");
8080

8181
% Verify.
@@ -98,7 +98,7 @@ function getVisualizeCommand_noData(testCase)
9898
results = mag.bart.Instrument();
9999

100100
% Exercise and verify.
101-
testCase.verifyError(@() signalAnalyzer.getVisualizeCommand(results), "mag:app:emptySignal", ...
101+
testCase.verifyError(@() signalAnalyzer.getVisualizeCommand(results), "mag:app:EmptySignal", ...
102102
"Error should be thrown when there is no data to plot.");
103103
end
104104
end

tests/unit/app/tVisualizationManager.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ function visualize_noSelection(testCase, VisualzationClass)
3535
manager.instantiate(panel);
3636

3737
% Exercise and verify.
38-
testCase.verifyError(@() manager.visualize([]), "mag:app:noViewSelected", ...
38+
testCase.verifyError(@() manager.visualize([]), "mag:app:NoViewSelected", ...
3939
"Error should be thrown when no view is selected.");
4040
end
4141
end

tests/unit/app/tWaveletAnalyzer.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ function getVisualizeCommand_noData(testCase)
103103
results = mag.bart.Instrument();
104104

105105
% Exercise and verify.
106-
testCase.verifyError(@() waveletAnalyzer.getVisualizeCommand(results), "mag:app:emptySignal", ...
106+
testCase.verifyError(@() waveletAnalyzer.getVisualizeCommand(results), "mag:app:EmptySignal", ...
107107
"Error should be thrown when there is no data to plot.");
108108
end
109109
end

0 commit comments

Comments
 (0)