Keeps adding closed TODS. Feature or bug?

[villiamriegler]

Problem description

Currently, we only account for open issues when deciding if a comment should be pushed as an issue. The problem with this approach is that closing the issue only results in it being readded as next time the action runs, to remove the issue permanently the comment also has to be removed. This may prove problematic for comments on the release branch as it should not be updated as often.

Arguments

Arguments against fixing this are first of all that the list of closed issues may be huge resulting in poor performance and a massive hashtable as previous issues are stored in memory. Secondly, todo comments should not be present on branches not currently being worked on however, this is probably not valid as the action should not dictate the workflow of a team. Lastly, we have to decide if this is a bug or a feature.

Arguments for this being a feature instead of a bug could be that it helps avoid accidentally closing issues that are not fixed. When something commented as a todo is fixed the developer should remove the comment. Again though the action should perhaps not dictate the workflow of a team.

[villiamriegler]

Examples of this being a bug are perhaps #190, where this was clearly not the case but in order to remove the issue the code has to be edited. However, this is more of a question than something to fix and maybe it should have been a man-made issue from the beginning instead of a comment.