Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete/Submit modes vary per mode #7

Open
andrewvanbreda opened this issue Oct 21, 2015 · 0 comments
Open

Delete/Submit modes vary per mode #7

andrewvanbreda opened this issue Oct 21, 2015 · 0 comments

Comments

@andrewvanbreda
Copy link
Contributor

After some investigation after an issue with NPMS, I discovered some problems with the elegance of the code that shows the Submit/Delete buttons on prebuilt forms

For instance, when I had the dynamic_sample_occurrence running in Wizard Mode it called getSubmitButtons (which is a method that appears in several prebuilt forms).
This always seemed to include a Delete button that appears before the Submit button, I will be committing a fix shortly that swaps the two button around (as this causes the Delete to fire when the Return key is pressed)
It also seems to have no way to remove the Delete button with configuration. Users are always able to delete their data even if we don't want them to (unless we use jQuery to hide).

I switched the screens to tabbed mode (with the "submit button below each tab" option on) and this seemed to call data_entry_helper::wizard_buttons, which doesn't display the delete button in the same situation.

It would be better if the same area of code was called to display the buttons no matter what the screen mode was. Currently very confusing. As I just mentioned, which buttons are displayed also seems to vary with the mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant