fix: Fix flickering in UploadOngoingScreen

Infomaniak · Mar 6, 2025 · 7629133 · 7629133
1 parent d64338b
commit 7629133
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadScreen.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadScreen.kt
@@ -59,15 +59,11 @@ fun UploadScreen(
         }
     )
 
-    @Composable
-    fun exit() {
-        if (hasPickedFiles) LaunchedEffect(navigateBackToPickFiles) { navigateBackToPickFiles() }
-        else LaunchedEffect(exitNewTransfer) { exitNewTransfer() }
-    }
-
     when (val state = uploadState) {
         null -> {
-            exit()
+            // Extracting the if/else below to a local composable function causes flickering, so leave it here.
+            if (hasPickedFiles) LaunchedEffect(navigateBackToPickFiles) { navigateBackToPickFiles() }
+            else LaunchedEffect(exitNewTransfer) { exitNewTransfer() }
             NoUploadOngoingEmptyState()
         }
         is UploadState.Ongoing -> UploadOngoingScreen(