fix: Fix flickering in UploadOngoingScreen

LouisCAD · LouisCAD · commit 76291333ff08 · 2025-03-06T14:28:16.000+01:00
diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadScreen.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadScreen.kt
@@ -59,15 +59,11 @@ fun UploadScreen(
         }
     )
 
-    @Composable
-    fun exit() {
-        if (hasPickedFiles) LaunchedEffect(navigateBackToPickFiles) { navigateBackToPickFiles() }
-        else LaunchedEffect(exitNewTransfer) { exitNewTransfer() }
-    }
-
     when (val state = uploadState) {
         null -> {
-            exit()
+            // Extracting the if/else below to a local composable function causes flickering, so leave it here.
+            if (hasPickedFiles) LaunchedEffect(navigateBackToPickFiles) { navigateBackToPickFiles() }
+            else LaunchedEffect(exitNewTransfer) { exitNewTransfer() }
             NoUploadOngoingEmptyState()
         }
         is UploadState.Ongoing -> UploadOngoingScreen(

Original file line number	Diff line number	Diff line change
`@@ -59,15 +59,11 @@ fun UploadScreen(`
`59`	`59`	`}`
`60`	`60`	`)`
`61`	`61`
`62`		`- @Composable`
`63`		`- fun exit() {`
`64`		`- if (hasPickedFiles) LaunchedEffect(navigateBackToPickFiles) { navigateBackToPickFiles() }`
`65`		`- else LaunchedEffect(exitNewTransfer) { exitNewTransfer() }`
`66`		`- }`
`67`		`-`
`68`	`62`	`when (val state = uploadState) {`
`69`	`63`	`null -> {`
`70`		`- exit()`
	`64`	`+ // Extracting the if/else below to a local composable function causes flickering, so leave it here.`
	`65`	`+ if (hasPickedFiles) LaunchedEffect(navigateBackToPickFiles) { navigateBackToPickFiles() }`
	`66`	`+ else LaunchedEffect(exitNewTransfer) { exitNewTransfer() }`
`71`	`67`	`NoUploadOngoingEmptyState()`
`72`	`68`	`}`
`73`	`69`	`is UploadState.Ongoing -> UploadOngoingScreen(`