fix(UrlFile): Fix opening an url file because of network on main thread

Author: FabianDevel

app/src/main/java/com/infomaniak/drive/ui/publicShare/OnPublicShareItemClickListener.kt

@@ -21,9 +21,9 @@ import android.content.Intent
 import androidx.annotation.StringRes
 import androidx.core.content.FileProvider
 import androidx.lifecycle.LifecycleOwner
+import androidx.lifecycle.lifecycleScope
 import com.infomaniak.drive.MatomoDrive.ACTION_DOWNLOAD_NAME
 import com.infomaniak.drive.MatomoDrive.trackPublicShareActionEvent
-import androidx.lifecycle.lifecycleScope
 import com.infomaniak.drive.R
 import com.infomaniak.drive.data.models.File
 import com.infomaniak.drive.ui.fileList.BaseDownloadProgressDialog.DownloadAction
@@ -99,7 +99,7 @@ interface OnPublicShareItemClickListener : FileInfoActionsView.OnItemClickListen
         }
     }
 
-    private fun executeDownloadAction(downloadAction: DownloadAction, cacheFile: IOFile) = runCatching {
+    private suspend fun executeDownloadAction(downloadAction: DownloadAction, cacheFile: IOFile) = runCatching {
         currentContext.trackPublicShareActionEvent(downloadAction.matomoValue)
         val uri = FileProvider.getUriForFile(currentContext, currentContext.getString(R.string.FILE_AUTHORITY), cacheFile)
 

app/src/main/java/com/infomaniak/drive/ui/publicShare/PublicShareListFragment.kt

@@ -264,15 +264,17 @@ class PublicShareListFragment : FileListFragment() {
         )
     }
 
-    private fun executeOpenBookmarkAction(cacheFile: IOFile?) = runCatching {
-        val uri = FileProvider.getUriForFile(requireContext(), getString(R.string.FILE_AUTHORITY), cacheFile!!)
-        with(requireContext()) {
-            trackPublicShareActionEvent(ACTION_OPEN_BOOKMARK_NAME)
-            openBookmarkIntent(cacheFile.name, uri)
+    private fun executeOpenBookmarkAction(cacheFile: IOFile?) = lifecycleScope.launch {
+        runCatching {
+            val uri = FileProvider.getUriForFile(requireContext(), getString(R.string.FILE_AUTHORITY), cacheFile!!)
+            with(requireContext()) {
+                trackPublicShareActionEvent(ACTION_OPEN_BOOKMARK_NAME)
+                openBookmarkIntent(cacheFile.name, uri)
+            }
+        }.onFailure { exception ->
+            exception.printStackTrace()
+            showSnackbar(title = R.string.errorGetBookmarkURL, anchor = importButton)
         }
-    }.onFailure { exception ->
-        exception.printStackTrace()
-        showSnackbar(title = R.string.errorGetBookmarkURL, anchor = importButton)
     }
 
     private fun downloadAllFiles() {

app/src/main/java/com/infomaniak/drive/utils/FilePresenter.kt

@@ -20,6 +20,7 @@ package com.infomaniak.drive.utils
 import android.content.Context
 import android.net.Uri
 import androidx.fragment.app.Fragment
+import androidx.lifecycle.lifecycleScope
 import androidx.navigation.fragment.findNavController
 import com.dd.plist.NSDictionary
 import com.dd.plist.NSString
@@ -44,6 +45,9 @@ import com.infomaniak.lib.core.utils.SnackbarUtils.showSnackbar
 import com.infomaniak.lib.core.utils.UtilsUi.openUrl
 import com.infomaniak.lib.core.utils.capitalizeFirstChar
 import com.infomaniak.lib.core.utils.safeNavigate
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 import java.io.BufferedInputStream
 import java.io.BufferedReader
 import java.io.InputStreamReader
@@ -109,7 +113,7 @@ object FilePresenter {
         }
     }
 
-    fun Fragment.openBookmarkIntent(file: File) {
+    fun Fragment.openBookmarkIntent(file: File) = lifecycleScope.launch {
         runCatching {
             val storedFileUri = file.getCloudAndFileUris(requireContext()).second
             requireActivity().openBookmarkIntent(file.name, storedFileUri)
@@ -121,11 +125,13 @@ object FilePresenter {
         }
     }
 
-    fun Context.openBookmarkIntent(fileName: String, uri: Uri) {
-        val url = if (fileName.endsWith(".url")) {
-            getUrlFromUrlFile(context = this, uri)
-        } else {
-            getUrlFromWebloc(context = this, uri)
+    suspend fun Context.openBookmarkIntent(fileName: String, uri: Uri) {
+        val url = withContext(Dispatchers.IO) {
+            if (fileName.endsWith(".url")) {
+                getUrlFromUrlFile(context = this@openBookmarkIntent, uri)
+            } else {
+                getUrlFromWebloc(context = this@openBookmarkIntent, uri)
+            }
         }
 
         if (url.isValidUrl()) openUrl(url) else throw Exception("It's not a valid url")