From cef939dd3e3eb36b10eee348e6793e432367f668 Mon Sep 17 00:00:00 2001 From: Vincent TE Date: Tue, 4 Mar 2025 08:38:00 +0100 Subject: [PATCH 1/2] chore: Update version of PDFview --- app/build.gradle | 2 +- .../drive/ui/fileList/preview/PreviewPDFFragment.kt | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/build.gradle b/app/build.gradle index 4cc664dd8e..3900ec1a58 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -153,7 +153,7 @@ dependencies { implementation "com.google.android.exoplayer:extension-okhttp:$exoplayer_version" implementation 'com.airbnb.android:lottie:6.6.2' - implementation 'com.github.Infomaniak:android-pdfview:3.2.10' + implementation 'com.github.Infomaniak:android-pdfview:3.2.11' implementation 'com.github.MikeOrtiz:TouchImageView:3.5' implementation 'com.github.rubensousa:gravitysnaphelper:2.2.2' implementation 'com.tbuonomo:dotsindicator:5.1.0' diff --git a/app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt b/app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt index 4d4e73fcd1..21497d7799 100644 --- a/app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt +++ b/app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt @@ -169,7 +169,7 @@ class PreviewPDFFragment : PreviewFragment(), PDFPrintListener { pageFling(false) pageSnap(false) scrollHandle(scrollHandle) - spacing(PDF_VIEW_HANDLE_TEXT_INDICATOR_SIZE_DP) + pageSeparatorSpacing(PDF_VIEW_HANDLE_TEXT_INDICATOR_SIZE_DP) startEndSpacing(START_END_SPACING_DP, START_END_SPACING_DP) zoom(MIN_ZOOM, MID_ZOOM, MAX_ZOOM) swipeHorizontal(false) @@ -341,7 +341,7 @@ class PreviewPDFFragment : PreviewFragment(), PDFPrintListener { companion object { private const val PDF_VIEW_HANDLE_TEXT_INDICATOR_SIZE_DP = 16 - private const val START_END_SPACING_DP = 200 + private const val START_END_SPACING_DP = 150 private const val MIN_ZOOM = 0.93f private const val MID_ZOOM = 3f private const val MAX_ZOOM = 6f From bceb8fb6400bc1fbcc3009178d22a05187ae5e3a Mon Sep 17 00:00:00 2001 From: Vincent TE Date: Thu, 6 Mar 2025 16:39:30 +0100 Subject: [PATCH 2/2] chore: Put a smaller margin at the end of a PDF --- .../drive/ui/fileList/preview/PreviewPDFFragment.kt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt b/app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt index 21497d7799..bd2e3f9db6 100644 --- a/app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt +++ b/app/src/main/java/com/infomaniak/drive/ui/fileList/preview/PreviewPDFFragment.kt @@ -170,7 +170,7 @@ class PreviewPDFFragment : PreviewFragment(), PDFPrintListener { pageSnap(false) scrollHandle(scrollHandle) pageSeparatorSpacing(PDF_VIEW_HANDLE_TEXT_INDICATOR_SIZE_DP) - startEndSpacing(START_END_SPACING_DP, START_END_SPACING_DP) + startEndSpacing(START_SPACING_DP, END_SPACING_DP) zoom(MIN_ZOOM, MID_ZOOM, MAX_ZOOM) swipeHorizontal(false) touchPriority(true) @@ -341,7 +341,8 @@ class PreviewPDFFragment : PreviewFragment(), PDFPrintListener { companion object { private const val PDF_VIEW_HANDLE_TEXT_INDICATOR_SIZE_DP = 16 - private const val START_END_SPACING_DP = 150 + private const val START_SPACING_DP = 150 + private const val END_SPACING_DP = 75 private const val MIN_ZOOM = 0.93f private const val MID_ZOOM = 3f private const val MAX_ZOOM = 6f