Remove magic number

KevinBoulongne · KevinBoulongne · commit 0879c643d28f · 2024-10-14T15:49:00.000+02:00
diff --git a/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt b/app/src/main/java/com/infomaniak/mail/ui/main/thread/ThreadViewModel.kt
@@ -259,7 +259,7 @@ class ThreadViewModel @Inject constructor(
             batchedMessages.postValue(ArrayList(output))
 
             if (batch.size < batchSize) return
-            delay(50L)
+            delay(DELAY_BETWEEN_EACH_BATCHED_MESSAGES)
             sendBatchesRecursively(input.subList(batchSize, input.size), output)
         }
 
@@ -471,5 +471,6 @@ class ThreadViewModel @Inject constructor(
     companion object {
         private const val SUPER_COLLAPSED_BLOCK_MINIMUM_MESSAGES_LIMIT = 5
         private const val SUPER_COLLAPSED_BLOCK_FIRST_INDEX_LIMIT = 3
+        private const val DELAY_BETWEEN_EACH_BATCHED_MESSAGES = 50L
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,7 @@ class ThreadViewModel @Inject constructor(`
`259`	`259`	`batchedMessages.postValue(ArrayList(output))`
`260`	`260`
`261`	`261`	`if (batch.size < batchSize) return`
`262`		`- delay(50L)`
	`262`	`+ delay(DELAY_BETWEEN_EACH_BATCHED_MESSAGES)`
`263`	`263`	`sendBatchesRecursively(input.subList(batchSize, input.size), output)`
`264`	`264`	`}`
`265`	`265`
`@@ -471,5 +471,6 @@ class ThreadViewModel @Inject constructor(`
`471`	`471`	`companion object {`
`472`	`472`	`private const val SUPER_COLLAPSED_BLOCK_MINIMUM_MESSAGES_LIMIT = 5`
`473`	`473`	`private const val SUPER_COLLAPSED_BLOCK_FIRST_INDEX_LIMIT = 3`
	`474`	`+ private const val DELAY_BETWEEN_EACH_BATCHED_MESSAGES = 50L`
`474`	`475`	`}`
`475`	`476`	`}`