Fix SonarCloud issue

Author: TommyDL-Infomaniak

app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/RefreshController.kt

@@ -736,11 +736,13 @@ class RefreshController @Inject constructor(
         }
 
         remoteMessage.initLocalValues(
-            date = remoteMessage.date,
-            isFullyDownloaded = false,
-            isTrashed = folder.role == FolderRole.TRASH,
-            isFromSearch = false,
-            draftLocalUuid = null,
+            Message.MessageInitialState(
+                date = remoteMessage.date,
+                isFullyDownloaded = false,
+                isTrashed = folder.role == FolderRole.TRASH,
+                isFromSearch = false,
+                draftLocalUuid = null,
+            ),
             latestCalendarEventResponse = null,
         )
 

app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/ThreadController.kt

@@ -98,11 +98,13 @@ class ThreadController @Inject constructor(
                 // The Search only returns Messages from TRASH if we explicitly selected this folder,
                 // which is the reason why we can compute the `isTrashed` value so loosely.
                 remoteMessage.initLocalValues(
-                    date = localMessage?.date ?: remoteMessage.date,
-                    isFullyDownloaded = localMessage?.isFullyDownloaded() ?: false,
-                    isTrashed = filterFolder?.role == FolderRole.TRASH,
-                    isFromSearch = localMessage == null,
-                    draftLocalUuid = localMessage?.draftLocalUuid,
+                    Message.MessageInitialState(
+                        date = localMessage?.date ?: remoteMessage.date,
+                        isFullyDownloaded = localMessage?.isFullyDownloaded() ?: false,
+                        isTrashed = filterFolder?.role == FolderRole.TRASH,
+                        isFromSearch = localMessage == null,
+                        draftLocalUuid = localMessage?.draftLocalUuid,
+                    ),
                     latestCalendarEventResponse = null,
                 )
 
@@ -313,11 +315,13 @@ class ThreadController @Inject constructor(
                                 } ?: realmListOf()
 
                                 remoteMessage.initLocalValues(
-                                    date = localMessage.date,
-                                    isFullyDownloaded = true,
-                                    isTrashed = localMessage.isTrashed,
-                                    isFromSearch = localMessage.isFromSearch,
-                                    draftLocalUuid = remoteMessage.getDraftLocalUuid(realm),
+                                    Message.MessageInitialState(
+                                        date = localMessage.date,
+                                        isFullyDownloaded = true,
+                                        isTrashed = localMessage.isTrashed,
+                                        isFromSearch = localMessage.isFromSearch,
+                                        draftLocalUuid = remoteMessage.getDraftLocalUuid(realm),
+                                    ),
                                     latestCalendarEventResponse = localMessage.latestCalendarEventResponse,
                                     messageIds = localMessage.messageIds,
                                     swissTransferFiles = swissTransferFiles

app/src/main/java/com/infomaniak/mail/data/models/message/Message.kt

@@ -209,21 +209,17 @@ class Message : RealmObject {
     }
 
     fun initLocalValues(
-        date: RealmInstant,
-        isFullyDownloaded: Boolean,
-        isTrashed: Boolean,
-        isFromSearch: Boolean,
-        draftLocalUuid: String?,
+        messageInitialState: MessageInitialState,
         latestCalendarEventResponse: CalendarEventResponse?,
         messageIds: RealmSet<String>? = null,
         swissTransferFiles: RealmList<SwissTransferFile> = realmListOf()
     ) {
 
-        this.date = date
-        this._isFullyDownloaded = isFullyDownloaded
-        this.isTrashed = isTrashed
-        draftLocalUuid?.let { this.draftLocalUuid = it }
-        this.isFromSearch = isFromSearch
+        this.date = messageInitialState.date
+        this._isFullyDownloaded = messageInitialState.isFullyDownloaded
+        this.isTrashed = messageInitialState.isTrashed
+        messageInitialState.draftLocalUuid?.let { this.draftLocalUuid = it }
+        this.isFromSearch = messageInitialState.isFromSearch
         this.messageIds = messageIds ?: computeMessageIds()
         this.latestCalendarEventResponse = latestCalendarEventResponse
         this.swissTransferFiles = swissTransferFiles
@@ -324,4 +320,12 @@ class Message : RealmObject {
     override fun equals(other: Any?) = other === this || (other is Message && other.uid == uid)
 
     override fun hashCode(): Int = uid.hashCode()
+
+    data class MessageInitialState(
+        val date: RealmInstant,
+        val isFullyDownloaded: Boolean,
+        val isTrashed: Boolean,
+        val isFromSearch: Boolean,
+        val draftLocalUuid: String?
+    )
 }