Correctly reset the insert dialog edit text states when opening the dialog again

LunarX · LunarX · commit 16f5d132a6cc · 2024-08-09T14:20:39.000+02:00
diff --git a/app/src/main/java/com/infomaniak/mail/ui/newMessage/InsertLinkDialog.kt b/app/src/main/java/com/infomaniak/mail/ui/newMessage/InsertLinkDialog.kt
@@ -55,12 +55,17 @@ class InsertLinkDialog @Inject constructor(
             .also {
                 it.setOnShowListener { dialog ->
                     displayNameEditText.showKeyboard()
-                    urlLayout.setError(null)
+                    resetDialogState()
                     setConfirmButtonListener(dialog)
                 }
             }
     }
 
+    private fun resetDialogState() {
+        binding.urlLayout.setError(null)
+        hidePlaceholder()
+    }
+
     private fun setConfirmButtonListener(dialog: DialogInterface) = with(binding) {
         (dialog as AlertDialog).getButton(AlertDialog.BUTTON_POSITIVE).setOnClickListener {
             val url = addMissingHttpsProtocol(urlEditText.trimmedText)

Original file line number	Diff line number	Diff line change
`@@ -55,12 +55,17 @@ class InsertLinkDialog @Inject constructor(`
`55`	`55`	`.also {`
`56`	`56`	`it.setOnShowListener { dialog ->`
`57`	`57`	`displayNameEditText.showKeyboard()`
`58`		`- urlLayout.setError(null)`
	`58`	`+ resetDialogState()`
`59`	`59`	`setConfirmButtonListener(dialog)`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`
	`64`	`+ private fun resetDialogState() {`
	`65`	`+ binding.urlLayout.setError(null)`
	`66`	`+ hidePlaceholder()`
	`67`	`+ }`
	`68`	`+`
`64`	`69`	`private fun setConfirmButtonListener(dialog: DialogInterface) = with(binding) {`
`65`	`70`	`(dialog as AlertDialog).getButton(AlertDialog.BUTTON_POSITIVE).setOnClickListener {`
`66`	`71`	`val url = addMissingHttpsProtocol(urlEditText.trimmedText)`