Delete Thread in Realm if it's empty and we're trying to display it in ThreadsList

Author: KevinBoulongne

app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/ThreadController.kt

@@ -159,6 +159,12 @@ class ThreadController @Inject constructor(
             }
         }
     }
+
+    fun deleteThread(threadUid: String) {
+        mailboxContentRealm().writeBlocking {
+            delete(getThreadQuery(threadUid, realm = this))
+        }
+    }
     //endregion
 
     companion object {

app/src/main/java/com/infomaniak/mail/ui/MainViewModel.kt

@@ -1047,6 +1047,10 @@ class MainViewModel @Inject constructor(
         snackbarManager.postValue(appContext.getString(snackbarTitleRes))
     }
 
+    fun deleteThreadInRealm(threadUid: String) = viewModelScope.launch(ioCoroutineContext) {
+        threadController.deleteThread(threadUid)
+    }
+
     private fun shouldAutoAdvance(message: Message?, threadsUids: List<String>): Boolean {
         val isWorkingWithThread = message == null
         return isWorkingWithThread || threadHasOnlyOneMessageLeftInCurrentFolder(threadsUids.first())

app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt

@@ -191,6 +191,14 @@ class ThreadListAdapter @Inject constructor(
 
     private fun CardviewThreadItemBinding.displayThread(thread: Thread, position: Int) {
 
+        // If we are trying to display an empty Thread, don't. Just delete it.
+        if (thread.messages.isEmpty()) {
+            // TODO: Find why we are sometimes displaying empty Threads, and fix it instead of just deleting them.
+            //  It's possibly because we are out of sync, and the situation will resolve itself shortly? ¯\_(ツ)_/¯
+            threadListAdapterCallback?.deleteThreadInRealm?.invoke(thread.uid)
+            return
+        }
+
         refreshCachedSelectedPosition(thread.uid, position) // If item changed position, update cached position.
         setupThreadDensityDependentUi()
         displayAvatar(thread)

app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapterCallback.kt

@@ -25,4 +25,5 @@ interface ThreadListAdapterCallback {
     var onFlushClicked: ((dialogTitle: String) -> Unit)?
     var onLoadMoreClicked: () -> Unit
     var onPositionClickedChanged: (position: Int, previousPosition: Int) -> Unit
+    var deleteThreadInRealm: (threadUid: String) -> Unit
 }

app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListFragment.kt

@@ -322,6 +322,8 @@ class ThreadListFragment : TwoPaneFragment(), SwipeRefreshLayout.OnRefreshListen
                 }
 
                 override var onPositionClickedChanged: (Int, Int) -> Unit = ::updateAutoAdvanceNaturalThread
+
+                override var deleteThreadInRealm: (String) -> Unit = { threadUid -> mainViewModel.deleteThreadInRealm(threadUid) }
             },
             multiSelection = object : MultiSelectionListener<Thread> {
                 override var isEnabled by mainViewModel::isMultiSelectOn

app/src/main/java/com/infomaniak/mail/ui/main/search/SearchFragment.kt

@@ -172,6 +172,8 @@ class SearchFragment : TwoPaneFragment() {
                 }
 
                 override var onPositionClickedChanged: (Int, Int) -> Unit = ::updateAutoAdvanceNaturalThread
+
+                override var deleteThreadInRealm: (String) -> Unit = { threadUid -> mainViewModel.deleteThreadInRealm(threadUid) }
             },
         )