Also delete Threads & add Sentry after finishing RefreshController

Author: KevinBoulongne

app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/RefreshController.kt

@@ -102,6 +102,9 @@ class RefreshController @Inject constructor(
         setupConfiguration(refreshMode, mailbox, folder, realm, okHttpClient, callbacks)
 
         return refreshWithRunCatching(refreshThreadsJob!!).also { (threads, _) ->
+
+            ThreadController.deleteEmptyThreadsInFolder(folder.id, realm)
+
             if (threads != null) {
                 onStop?.invoke()
                 SentryLog.d("API", "End of refreshing threads with mode: $refreshMode | (${folder.displayForSentry()})")

app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/ThreadController.kt

@@ -28,6 +28,7 @@ import com.infomaniak.mail.data.models.thread.Thread.ThreadFilter
 import com.infomaniak.mail.di.IoDispatcher
 import com.infomaniak.mail.utils.ErrorCode
 import com.infomaniak.mail.utils.SearchUtils.Companion.convertToSearchThreads
+import com.infomaniak.mail.utils.SentryDebug
 import io.realm.kotlin.MutableRealm
 import io.realm.kotlin.Realm
 import io.realm.kotlin.TypedRealm
@@ -214,6 +215,12 @@ class ThreadController @Inject constructor(
         private fun getThreadQuery(uid: String, realm: TypedRealm): RealmSingleQuery<Thread> {
             return realm.query<Thread>("${Thread::uid.name} == $0", uid).first()
         }
+
+        private fun getEmptyThreadsInFolderQuery(folderId: String, realm: TypedRealm): RealmQuery<Thread> {
+            val noMessages = "${Thread::messages.name}.@size == $0"
+            return FolderController.getFolder(folderId, realm)?.threads?.query(noMessages, 0)
+                ?: realm.query<Thread>("$noMessages AND ${Thread::folderId.name} == $1", 0, folderId)
+        }
         //endregion
 
         //region Get data
@@ -325,7 +332,22 @@ class ThreadController @Inject constructor(
         }
 
         fun deleteSearchThreads(realm: MutableRealm) = with(realm) {
-            delete(query<Thread>("${Thread::isFromSearch.name} == true").find())
+            delete(query<Thread>("${Thread::isFromSearch.name} == true"))
+        }
+
+        fun deleteEmptyThreadsInFolder(folderId: String, realm: Realm) {
+            realm.writeBlocking {
+                val emptyThreadsQuery = getEmptyThreadsInFolderQuery(folderId, realm = this)
+                val emptyThreads = emptyThreadsQuery.find()
+                // TODO: Find why we are sometimes displaying empty Threads, and fix it instead of just deleting them.
+                //  It's possibly because we are out of sync, and the situation will resolve by itself shortly?
+                if (emptyThreads.isNotEmpty()) {
+                    emptyThreads.forEach {
+                        SentryDebug.sendEmptyThread(it, "No Message in a Thread when refreshing a Folder")
+                    }
+                    delete(emptyThreadsQuery)
+                }
+            }
         }
 
         private fun verifyAttachmentsValues(hasAttachmentsInThread: Boolean, messages: List<Message>, realm: MutableRealm) {

app/src/main/java/com/infomaniak/mail/ui/main/folder/ThreadListAdapter.kt

@@ -195,7 +195,7 @@ class ThreadListAdapter @Inject constructor(
         // If we are trying to display an empty Thread, don't. Just delete it.
         if (thread.messages.isEmpty()) {
             // TODO: Find why we are sometimes displaying empty Threads, and fix it instead of just deleting them.
-            //  It's possibly because we are out of sync, and the situation will resolve itself shortly? ¯\_(ツ)_/¯
+            //  It's possibly because we are out of sync, and the situation will resolve by itself shortly?
             threadListAdapterCallback?.deleteThreadInRealm?.invoke(thread.uid)
             SentryDebug.sendEmptyThread(thread, "No Message in the Thread when displaying it in ThreadList")
             return

app/src/main/java/com/infomaniak/mail/utils/SentryDebug.kt

@@ -118,7 +118,7 @@ object SentryDebug {
     // TODO: Added the 04/09/23. It's not supposed to be possible, but we never know…
     //  If this doesn't trigger after a certain amount of time, you can remove it.
     //
-    //  Also added in ThreadListAdapter the 31/05/24.
+    //  Also added in ThreadListAdapter & ThreadController the 04/06/24.
     fun sendEmptyThread(thread: Thread, message: String) = with(thread) {
         Sentry.withScope { scope ->
             scope.setExtra("currentUserId", "${AccountUtils.currentUserId}")