Remove useless code

Author: tevincent

app/src/main/java/com/infomaniak/mail/ui/main/settings/SettingsFragment.kt

@@ -28,7 +28,6 @@ import com.infomaniak.lib.applock.Utils.isKeyguardSecure
 import com.infomaniak.lib.applock.Utils.silentlyReverseSwitch
 import com.infomaniak.lib.core.utils.openAppNotificationSettings
 import com.infomaniak.lib.core.utils.safeBinding
-import com.infomaniak.lib.core.utils.safeNavigate
 import com.infomaniak.lib.core.utils.showToast
 import com.infomaniak.mail.MatomoMail.toFloat
 import com.infomaniak.mail.MatomoMail.trackEvent
@@ -52,8 +51,6 @@ class SettingsFragment : Fragment() {
     private var binding: FragmentSettingsBinding by safeBinding()
     private val mainViewModel: MainViewModel by activityViewModels()
 
-    private val currentClassName: String = SettingsFragment::class.java.name
-
     @Inject
     lateinit var localSettings: LocalSettings
 
@@ -71,7 +68,6 @@ class SettingsFragment : Fragment() {
         setSystemBarsColors()
 
         setupMailboxesAdapter()
-        setupAddMailbox()
         setupListeners()
         setSubtitlesInitialState()
         observeFeatureFlag()
@@ -97,15 +93,6 @@ class SettingsFragment : Fragment() {
         mainViewModel.mailboxesLive.observe(viewLifecycleOwner, mailboxesAdapter::setMailboxes)
     }
 
-    private fun setupAddMailbox() = with(binding) {
-        addMailbox.setOnClickListener {
-            safeNavigate(
-                resId = R.id.attachMailboxFragment,
-                currentClassName = currentClassName,
-            )
-        }
-    }
-
     private fun setSubtitlesInitialState() = with(binding) {
         with(localSettings) {
             settingsAiEngine.setSubtitle(aiEngine.localisedNameRes)
@@ -123,6 +110,7 @@ class SettingsFragment : Fragment() {
     }
 
     private fun setupListeners() = with(binding) {
+        addMailbox.setOnClickListener { animatedNavigation(resId = R.id.attachMailboxFragment) }
 
         settingsNotifications.setOnClickListener {
             trackEvent("settingsNotifications", "openNotificationSettings")

app/src/main/res/layout/bottom_sheet_account.xml

@@ -24,8 +24,8 @@
     tools:title="My Account">
 
     <!--
-        We use useDefaultLayout to true, which embed recyclerViewAccount into a NestedScrollView. This
-        This prevent elements of the RecyclerView to be recycled. It should not be a big problem
+        We use useDefaultLayout to true, which embeds recyclerViewAccount into a NestedScrollView.
+        This prevents elements of the RecyclerView to be recycled. It should not be a big problem
         since we shouldn't have a lot of items here but this can be improved.
     -->
 

app/src/main/res/layout/fragment_attach_mailbox.xml

@@ -21,7 +21,7 @@
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     app:title="@string/buttonAddEmailAddress"
-    tools:context=".ui.main.user.AccountFragment">
+    tools:context="com.infomaniak.mail.ui.main.user.AttachMailboxFragment">
 
     <androidx.core.widget.NestedScrollView
         android:layout_width="match_parent"