Merge pull request #1719 from Infomaniak/fix-unfavorite

Allow to unfavorite Drafts

Author: KevinBoulongne

app/src/main/java/com/infomaniak/mail/data/api/ApiRepository.kt

@@ -215,11 +215,11 @@ object ApiRepository : ApiRepositoryCore() {
     fun getDraft(messageDraftResource: String): ApiResponse<Draft> = callApi(ApiRoutes.resource(messageDraftResource), GET)
 
     fun addToFavorites(mailboxUuid: String, messageUids: List<String>): ApiResponse<Unit> {
-        return starMessages(mailboxUuid, messageUids, true)
+        return starMessages(mailboxUuid, messageUids, star = true)
     }
 
     fun removeFromFavorites(mailboxUuid: String, messageUids: List<String>): ApiResponse<Unit> {
-        return starMessages(mailboxUuid, messageUids, false)
+        return starMessages(mailboxUuid, messageUids, star = false)
     }
 
     private fun starMessages(mailboxUuid: String, messageIds: List<String>, star: Boolean): ApiResponse<Unit> {

app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/MessageController.kt

@@ -74,8 +74,7 @@ class MessageController @Inject constructor(private val mailboxContentRealm: Rea
     }
 
     fun getFavoriteMessages(thread: Thread): List<Message> {
-        val isFavorite = "${Message::isFavorite.name} == true"
-        return getMessagesAndDuplicates(thread, "$isFavorite AND $isNotDraft")
+        return getMessagesAndDuplicates(thread, "${Message::isFavorite.name} == true")
     }
 
     fun getMovableMessages(thread: Thread): List<Message> {