Fix code smell

Author: tevincent

app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/ThreadController.kt

@@ -284,38 +284,23 @@ class ThreadController @Inject constructor(
             onUpdate(getThread(threadUid, realm))
         }
 
-        /**
-         * Asynchronously fetches heavy data for a list of messages within a given mailbox and realm.
-         *
-         * This function fetches heavy data associated with the provided list of messages, such as attachments
-         * or other resource-intensive content. It operates within the given realm and mailbox context.
-         *
-         * This function is deliberately present here as it relies on a method accessible solely through injection.
-         *
-         * @param messages List of messages for which heavy data needs to be fetched.
-         * @param realm The realm context in which the heavy data fetching and updates should occur.
-         * @param okHttpClient An optional OkHttpClient instance to use for making network requests.
-         *                     If not provided, a default client will be used.
-         */
-        fun fetchMessagesHeavyData(
-            messages: List<Message>,
-            realm: Realm,
-            okHttpClient: OkHttpClient? = null,
-        ): Pair<List<String>, List<String>> {
-
-            val deletedMessagesUids = mutableListOf<String>()
-            val failedMessagesUids = mutableListOf<String>()
-
-            fun fetchSwissTransferContainer(uuid: String): SwissTransferContainer? = runCatching {
+        private fun fetchSwissTransferContainer(uuid: String): SwissTransferContainer? {
+            return runCatching {
                 val apiResponse = ApiRepository.getSwissTransferContainer(uuid)
 
                 if (apiResponse.isSuccess()) return@runCatching apiResponse.data
 
                 SentryLog.i(TAG, "Could not fetch SwissTransfer container")
                 return@runCatching null
             }.getOrNull()
+        }
 
-            val apiCallsResults = messages.mapNotNull { localMessage ->
+        private fun getApiCallsResults(
+            messages: List<Message>,
+            okHttpClient: OkHttpClient?,
+            failedMessagesUids: MutableList<String>
+        ): List<ApiCallsResults> {
+            return messages.mapNotNull { localMessage ->
                 return@mapNotNull runCatching {
                     val apiResponse = ApiRepository.getMessage(localMessage.resource, okHttpClient)
                     val swissTransferUuid = apiResponse.data?.swissTransferUuid
@@ -330,6 +315,31 @@ class ThreadController @Inject constructor(
                     return@getOrElse null
                 }
             }
+        }
+
+        /**
+         * Asynchronously fetches heavy data for a list of messages within a given mailbox and realm.
+         *
+         * This function fetches heavy data associated with the provided list of messages, such as attachments
+         * or other resource-intensive content. It operates within the given realm and mailbox context.
+         *
+         * This function is deliberately present here as it relies on a method accessible solely through injection.
+         *
+         * @param messages List of messages for which heavy data needs to be fetched.
+         * @param realm The realm context in which the heavy data fetching and updates should occur.
+         * @param okHttpClient An optional OkHttpClient instance to use for making network requests.
+         *                     If not provided, a default client will be used.
+         */
+        fun fetchMessagesHeavyData(
+            messages: List<Message>,
+            realm: Realm,
+            okHttpClient: OkHttpClient? = null,
+        ): Pair<List<String>, List<String>> {
+
+            val deletedMessagesUids = mutableListOf<String>()
+            val failedMessagesUids = mutableListOf<String>()
+
+            val apiCallsResults = getApiCallsResults(messages, okHttpClient, failedMessagesUids)
 
             realm.writeBlocking {
                 var hasAttachableInThread = false

app/src/main/java/com/infomaniak/mail/data/models/thread/Thread.kt

@@ -91,7 +91,8 @@ class Thread : RealmObject {
     var isFromSearch: Boolean = false
     @Transient
     var hasAttachable: Boolean = false
-    // Has been moved (archived, spammed, deleted, moved) but API call hasn't been done yet. Used to filter locally the Threads' list.
+    // Has been moved (archived, spammed, deleted, moved) but API call hasn't been done yet.
+    // It's only used to filter locally the Threads' list.
     @Transient
     var isLocallyMovedOut: Boolean = false
     //endregion