refactor(MyKSuiteBlockSignature): Create another utils for Ui and remove useless FrameLayout

Author: FabianDevel

app/src/main/java/com/infomaniak/mail/ui/main/settings/mailbox/SignatureSettingFragment.kt

@@ -30,7 +30,7 @@ import com.infomaniak.mail.BuildConfig
 import com.infomaniak.mail.data.models.mailbox.Mailbox
 import com.infomaniak.mail.data.models.signature.Signature
 import com.infomaniak.mail.databinding.FragmentSignatureSettingBinding
-import com.infomaniak.mail.utils.MyKSuiteDataUtils.openMyKSuiteUpgradeBottomSheet
+import com.infomaniak.mail.utils.MyKSuiteUiUtils.openMyKSuiteUpgradeBottomSheet
 import com.infomaniak.mail.utils.extensions.setSystemBarsColors
 import dagger.hilt.android.AndroidEntryPoint
 import io.realm.kotlin.ext.copyFromRealm

app/src/main/java/com/infomaniak/mail/utils/MyKSuiteDataUtils.kt

@@ -17,13 +17,8 @@
  */
 package com.infomaniak.mail.utils
 
-import androidx.fragment.app.Fragment
 import com.infomaniak.core.myksuite.ui.data.MyKSuiteData
 import com.infomaniak.core.myksuite.ui.data.MyKSuiteDataManager
-import com.infomaniak.core.myksuite.ui.screens.KSuiteApp
-import com.infomaniak.core.myksuite.ui.views.MyKSuiteUpgradeBottomSheetDialogArgs
-import com.infomaniak.lib.core.utils.safeNavigate
-import com.infomaniak.mail.R
 import com.infomaniak.mail.data.cache.appSettings.AppSettingsController
 import com.infomaniak.mail.data.models.AppSettings
 
@@ -42,9 +37,4 @@ object MyKSuiteDataUtils : MyKSuiteDataManager() {
             field = myKSuiteData
             myKSuiteId = myKSuiteData?.id ?: AppSettings.DEFAULT_ID
         }
-
-    fun Fragment.openMyKSuiteUpgradeBottomSheet(currentClassName: String? = null) {
-        val args = MyKSuiteUpgradeBottomSheetDialogArgs(kSuiteApp = KSuiteApp.Mail)
-        safeNavigate(R.id.myKSuiteUpgradeBottomSheet, args.toBundle(), currentClassName = currentClassName)
-    }
 }

app/src/main/java/com/infomaniak/mail/utils/MyKSuiteUiUtils.kt

@@ -0,0 +1,32 @@
+/*
+ * Infomaniak Mail - Android
+ * Copyright (C) 2025 Infomaniak Network SA
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+package com.infomaniak.mail.utils
+
+import androidx.fragment.app.Fragment
+import com.infomaniak.core.myksuite.ui.screens.KSuiteApp
+import com.infomaniak.core.myksuite.ui.views.MyKSuiteUpgradeBottomSheetDialogArgs
+import com.infomaniak.lib.core.utils.safeNavigate
+import com.infomaniak.mail.R
+
+object MyKSuiteUiUtils {
+
+    fun Fragment.openMyKSuiteUpgradeBottomSheet(currentClassName: String? = null) {
+        val args = MyKSuiteUpgradeBottomSheetDialogArgs(kSuiteApp = KSuiteApp.Mail)
+        safeNavigate(R.id.myKSuiteUpgradeBottomSheet, args.toBundle(), currentClassName = currentClassName)
+    }
+}

app/src/main/res/layout/view_setting_radio_button.xml

@@ -40,25 +40,20 @@
         android:layout_weight="1"
         tools:text="Simple messages" />
 
-    <FrameLayout
-        android:layout_width="wrap_content"
-        android:layout_height="wrap_content">
-
-        <ImageView
-            android:id="@+id/checkMark"
-            android:layout_width="@dimen/mediumIconSize"
-            android:layout_height="@dimen/mediumIconSize"
-            android:layout_marginStart="@dimen/marginStandardMedium"
-            android:contentDescription="@string/contentDescriptionSelectedItem"
-            android:src="@drawable/ic_check"
-            android:visibility="invisible"
-            app:tint="?android:attr/colorPrimary" />
+    <ImageView
+        android:id="@+id/checkMark"
+        android:layout_width="@dimen/mediumIconSize"
+        android:layout_height="@dimen/mediumIconSize"
+        android:layout_marginStart="@dimen/marginStandardMedium"
+        android:contentDescription="@string/contentDescriptionSelectedItem"
+        android:src="@drawable/ic_check"
+        android:visibility="invisible"
+        app:tint="?android:attr/colorPrimary" />
 
-        <com.infomaniak.core.myksuite.ui.views.MyKSuitePlusChipView
-            android:id="@+id/myKSuitePlusChip"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:visibility="gone"
-            tools:visibility="visible" />
-    </FrameLayout>
+    <com.infomaniak.core.myksuite.ui.views.MyKSuitePlusChipView
+        android:id="@+id/myKSuitePlusChip"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:visibility="gone"
+        tools:visibility="visible" />
 </LinearLayout>