From bca8f744ef0e8dd4b9ee828c16cbb4977a440a6f Mon Sep 17 00:00:00 2001 From: Gibran Chevalley Date: Tue, 11 Mar 2025 11:35:37 +0100 Subject: [PATCH] refactor: Remove `when` to put some logic in common with multiple cases --- .../infomaniak/mail/utils/extensions/Extensions.kt | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/app/src/main/java/com/infomaniak/mail/utils/extensions/Extensions.kt b/app/src/main/java/com/infomaniak/mail/utils/extensions/Extensions.kt index 90bfb90e79..30b49e98d0 100644 --- a/app/src/main/java/com/infomaniak/mail/utils/extensions/Extensions.kt +++ b/app/src/main/java/com/infomaniak/mail/utils/extensions/Extensions.kt @@ -421,15 +421,11 @@ fun List.addDividerBeforeFirstCustomFolder(dividerType: Any): List fun List.getFoldersIds(exception: String? = null): ImpactedFolders { val impactedFolders = ImpactedFolders() - forEach { message -> - when { - message.folderId == exception -> Unit - message.snoozeState == SnoozeState.Snoozed -> { - impactedFolders += message.folderId - impactedFolders += FolderRole.SNOOZED - } - else -> impactedFolders += message.folderId - } + for (message in this) { + if (message.folderId == exception) continue + + impactedFolders += message.folderId + if (message.snoozeState == SnoozeState.Snoozed) impactedFolders += FolderRole.SNOOZED } return impactedFolders