refactor: Directly delete Messages in Realm, it will automatically remove them from their Threads

Author: KevinBoulongne

app/src/main/java/com/infomaniak/mail/data/cache/mailboxContent/RefreshController.kt

@@ -449,21 +449,8 @@ class RefreshController @Inject constructor(
 
         shortUids.forEach { shortUid ->
             scope.ensureActive()
-
             val message = MessageController.getMessage(uid = shortUid.toLongUid(folderId), realm = this) ?: return@forEach
-
-            /**
-             * This list is reversed because we'll delete items while looping over it.
-             * Doing so for managed Realm objects will lively update the list we're iterating through, making us skip the next item.
-             * Looping in reverse enables us to not skip any item.
-             */
-            message.threads.asReversed().forEach { thread ->
-                scope.ensureActive()
-
-                val isSuccess = thread.messages.remove(message)
-                if (isSuccess) threads += thread
-            }
-
+            threads += message.threads
             MessageController.deleteMessage(appContext, mailbox, message, realm = this)
         }