You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is reasonable to use np.sum() to determine the required capacity of a LaserFrame. However, the result of np.sum() is of type numpy.int64 which does not pass the test of isinstance(s, int).
That means the following test fails and it is a hassle to have to cast the result of np.sum() to a Python int to create a LaserFrame:
It is reasonable to use
np.sum()
to determine the required capacity of a LaserFrame. However, the result ofnp.sum()
is of typenumpy.int64
which does not pass the test ofisinstance(s, int)
.That means the following test fails and it is a hassle to have to cast the result of
np.sum()
to a Pythonint
to create aLaserFrame
:https://github.com/InstituteforDiseaseModeling/laser/blob/main/src/laser_core/laserframe.py#L59
The test should include NumPy integer types, e.g.
This is probably true for the test of
initial_count
as well.The text was updated successfully, but these errors were encountered: