Skip to content

Commit cc143ed

Browse files
derekmaurocopybara-github
authored andcommitted
Refactor the throw_delegate test into separate test cases
PiperOrigin-RevId: 487592054 Change-Id: Iff24f6e2a304fbc85843f10417fc3343c41333da
1 parent b4a4a6b commit cc143ed

File tree

1 file changed

+56
-2
lines changed

1 file changed

+56
-2
lines changed

absl/base/throw_delegate_test.cc

Lines changed: 56 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,29 +78,83 @@ void ExpectThrowNoWhat(void (*f)()) {
7878
#endif
7979
}
8080

81-
TEST(ThrowHelper, Test) {
82-
// Not using EXPECT_THROW because we want to check the .what() message too.
81+
TEST(ThrowDelegate, ThrowStdLogicErrorChar) {
8382
ExpectThrowChar<std::logic_error>(ThrowStdLogicError);
83+
}
84+
85+
TEST(ThrowDelegate, ThrowStdInvalidArgumentChar) {
8486
ExpectThrowChar<std::invalid_argument>(ThrowStdInvalidArgument);
87+
}
88+
89+
TEST(ThrowDelegate, ThrowStdDomainErrorChar) {
8590
ExpectThrowChar<std::domain_error>(ThrowStdDomainError);
91+
}
92+
93+
TEST(ThrowDelegate, ThrowStdLengthErrorChar) {
8694
ExpectThrowChar<std::length_error>(ThrowStdLengthError);
95+
}
96+
97+
TEST(ThrowDelegate, ThrowStdOutOfRangeChar) {
8798
ExpectThrowChar<std::out_of_range>(ThrowStdOutOfRange);
99+
}
100+
101+
TEST(ThrowDelegate, ThrowStdRuntimeErrorChar) {
88102
ExpectThrowChar<std::runtime_error>(ThrowStdRuntimeError);
103+
}
104+
105+
TEST(ThrowDelegate, ThrowStdRangeErrorChar) {
89106
ExpectThrowChar<std::range_error>(ThrowStdRangeError);
107+
}
108+
109+
TEST(ThrowDelegate, ThrowStdOverflowErrorChar) {
90110
ExpectThrowChar<std::overflow_error>(ThrowStdOverflowError);
111+
}
112+
113+
TEST(ThrowDelegate, ThrowStdUnderflowErrorChar) {
91114
ExpectThrowChar<std::underflow_error>(ThrowStdUnderflowError);
115+
}
92116

117+
TEST(ThrowDelegate, ThrowStdLogicErrorString) {
93118
ExpectThrowString<std::logic_error>(ThrowStdLogicError);
119+
}
120+
121+
TEST(ThrowDelegate, ThrowStdInvalidArgumentString) {
94122
ExpectThrowString<std::invalid_argument>(ThrowStdInvalidArgument);
123+
}
124+
125+
TEST(ThrowDelegate, ThrowStdDomainErrorString) {
95126
ExpectThrowString<std::domain_error>(ThrowStdDomainError);
127+
}
128+
129+
TEST(ThrowDelegate, ThrowStdLengthErrorString) {
96130
ExpectThrowString<std::length_error>(ThrowStdLengthError);
131+
}
132+
133+
TEST(ThrowDelegate, ThrowStdOutOfRangeString) {
97134
ExpectThrowString<std::out_of_range>(ThrowStdOutOfRange);
135+
}
136+
137+
TEST(ThrowDelegate, ThrowStdRuntimeErrorString) {
98138
ExpectThrowString<std::runtime_error>(ThrowStdRuntimeError);
139+
}
140+
141+
TEST(ThrowDelegate, ThrowStdRangeErrorString) {
99142
ExpectThrowString<std::range_error>(ThrowStdRangeError);
143+
}
144+
145+
TEST(ThrowDelegate, ThrowStdOverflowErrorString) {
100146
ExpectThrowString<std::overflow_error>(ThrowStdOverflowError);
147+
}
148+
149+
TEST(ThrowDelegate, ThrowStdUnderflowErrorString) {
101150
ExpectThrowString<std::underflow_error>(ThrowStdUnderflowError);
151+
}
102152

153+
TEST(ThrowDelegate, ThrowStdBadFunctionCallNoWhat) {
103154
ExpectThrowNoWhat<std::bad_function_call>(ThrowStdBadFunctionCall);
155+
}
156+
157+
TEST(ThrowDelegate, ThrowStdBadAllocNoWhat) {
104158
ExpectThrowNoWhat<std::bad_alloc>(ThrowStdBadAlloc);
105159
}
106160

0 commit comments

Comments
 (0)