Skip to content

Commit 1bb7e5a

Browse files
authored
Remove outdated actions and replace where possible (#138)
* Remove outdated actions and replace where possible * Forgot to update the one that was actually failing * Disable alpine functionality check Until the node20+ used by github runners works (see actions/runner#801) we can't run a test for alpine compatibility.
1 parent 0425606 commit 1bb7e5a

File tree

1 file changed

+38
-49
lines changed

1 file changed

+38
-49
lines changed

.github/workflows/typescript-napi-ci.yaml

Lines changed: 38 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -46,61 +46,50 @@ jobs:
4646
node-version: ${{ matrix.node_version }}
4747
cache: yarn
4848
architecture: ${{ matrix.system.arch }}
49-
- uses: actions-rs/toolchain@v1
49+
- uses: IronCoreLabs/rust-toolchain@v1
5050
with:
51-
profile: minimal
5251
toolchain: ${{ matrix.rust_version }}
53-
override: true
5452
- name: Install modules
5553
run: yarn install --ignore-scripts
5654
- name: Compile
5755
run: yarn run compile
5856
- name: Run tests
5957
run: yarn run test
60-
- name: Check test coverage
61-
if: ${{ contains(matrix.system.os, 'ubuntu') && matrix.node_version == '16'
62-
&& matrix.rust_version == 'stable' && github.base_ref != '' }}
63-
uses: anuraag016/[email protected]
64-
with:
65-
fullCoverageDiff: false
66-
delta: 0.2
67-
afterSwitchCommand: yarn install --ignore-scripts && yarn run compile
68-
accessToken: ${{ secrets.WORKFLOW_PAT }}
6958

70-
test-docker:
71-
runs-on: ${{ matrix.os }}
72-
container:
73-
image: node:${{ matrix.node_version }}-alpine
74-
strategy:
75-
matrix:
76-
rust_version:
77-
- stable
78-
- beta
79-
node_version:
80-
- 16
81-
- 18
82-
- 20
83-
- 21
84-
os:
85-
- buildjet-2vcpu-ubuntu-2204
86-
- buildjet-4vcpu-ubuntu-2204-arm
87-
fail-fast: false
88-
steps:
89-
- run: apk add build-base git python3 wget
90-
# https://github.com/actions/runner/issues/801#issuecomment-1374967227
91-
- run: |
92-
apk add gcompat
93-
sed -i "s:ID=alpine:ID=NotpineForGHA:" /etc/os-release
94-
- run: echo RUSTFLAGS="-C target-feature=-crt-static" >> "${GITHUB_ENV}"
95-
- uses: actions/checkout@v3
96-
- uses: actions-rs/toolchain@v1
97-
with:
98-
profile: minimal
99-
toolchain: ${{ matrix.rust_version }}
100-
override: true
101-
- name: Install modules
102-
run: yarn install --ignore-scripts
103-
- name: Compile
104-
run: yarn run compile
105-
- name: Run tests
106-
run: yarn run test
59+
# broken now that node20 is forced even for checkout@v3, which doesn't work using the # WORKAROUND below any more.
60+
# test-docker:
61+
# runs-on: ${{ matrix.os }}
62+
# container:
63+
# image: node:${{ matrix.node_version }}-alpine
64+
# strategy:
65+
# matrix:
66+
# rust_version:
67+
# - stable
68+
# - beta
69+
# node_version:
70+
# - 16
71+
# - 18
72+
# - 20
73+
# - 21
74+
# os:
75+
# - buildjet-2vcpu-ubuntu-2204
76+
# - buildjet-4vcpu-ubuntu-2204-arm
77+
# fail-fast: false
78+
# steps:
79+
# - run: apk add build-base git python3 wget
80+
# # WORKAROUND
81+
# # https://github.com/actions/runner/issues/801#issuecomment-1374967227
82+
# - run: |
83+
# apk add gcompat
84+
# sed -i "s:ID=alpine:ID=NotpineForGHA:" /etc/os-release
85+
# - run: echo RUSTFLAGS="-C target-feature=-crt-static" >> "${GITHUB_ENV}"
86+
# - uses: actions/checkout@v4
87+
# - uses: IronCoreLabs/rust-toolchain@v1
88+
# with:
89+
# toolchain: ${{ matrix.rust_version }}
90+
# - name: Install modules
91+
# run: yarn install --ignore-scripts
92+
# - name: Compile
93+
# run: yarn run compile
94+
# - name: Run tests
95+
# run: yarn run test

0 commit comments

Comments
 (0)