Skip to content

Commit 3435193

Browse files
committed
Disable alpine functionality check
Until the node20+ used by github runners works (see actions/runner#801) we can't run a test for alpine compatibility.
1 parent ae81bda commit 3435193

File tree

1 file changed

+37
-39
lines changed

1 file changed

+37
-39
lines changed

.github/workflows/typescript-napi-ci.yaml

Lines changed: 37 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -48,50 +48,48 @@ jobs:
4848
architecture: ${{ matrix.system.arch }}
4949
- uses: IronCoreLabs/rust-toolchain@v1
5050
with:
51-
profile: minimal
5251
toolchain: ${{ matrix.rust_version }}
53-
override: true
5452
- name: Install modules
5553
run: yarn install --ignore-scripts
5654
- name: Compile
5755
run: yarn run compile
5856
- name: Run tests
5957
run: yarn run test
6058

61-
test-docker:
62-
runs-on: ${{ matrix.os }}
63-
container:
64-
image: node:${{ matrix.node_version }}-alpine
65-
strategy:
66-
matrix:
67-
rust_version:
68-
- stable
69-
- beta
70-
node_version:
71-
- 16
72-
- 18
73-
- 20
74-
- 21
75-
os:
76-
- buildjet-2vcpu-ubuntu-2204
77-
- buildjet-4vcpu-ubuntu-2204-arm
78-
fail-fast: false
79-
steps:
80-
- run: apk add build-base git python3 wget
81-
# https://github.com/actions/runner/issues/801#issuecomment-1374967227
82-
- run: |
83-
apk add gcompat
84-
sed -i "s:ID=alpine:ID=NotpineForGHA:" /etc/os-release
85-
- run: echo RUSTFLAGS="-C target-feature=-crt-static" >> "${GITHUB_ENV}"
86-
- uses: actions/checkout@v4
87-
- uses: IronCoreLabs/rust-toolchain@v1
88-
with:
89-
profile: minimal
90-
toolchain: ${{ matrix.rust_version }}
91-
override: true
92-
- name: Install modules
93-
run: yarn install --ignore-scripts
94-
- name: Compile
95-
run: yarn run compile
96-
- name: Run tests
97-
run: yarn run test
59+
# broken now that node20 is forced even for checkout@v3, which doesn't work using the # WORKAROUND below any more.
60+
# test-docker:
61+
# runs-on: ${{ matrix.os }}
62+
# container:
63+
# image: node:${{ matrix.node_version }}-alpine
64+
# strategy:
65+
# matrix:
66+
# rust_version:
67+
# - stable
68+
# - beta
69+
# node_version:
70+
# - 16
71+
# - 18
72+
# - 20
73+
# - 21
74+
# os:
75+
# - buildjet-2vcpu-ubuntu-2204
76+
# - buildjet-4vcpu-ubuntu-2204-arm
77+
# fail-fast: false
78+
# steps:
79+
# - run: apk add build-base git python3 wget
80+
# # WORKAROUND
81+
# # https://github.com/actions/runner/issues/801#issuecomment-1374967227
82+
# - run: |
83+
# apk add gcompat
84+
# sed -i "s:ID=alpine:ID=NotpineForGHA:" /etc/os-release
85+
# - run: echo RUSTFLAGS="-C target-feature=-crt-static" >> "${GITHUB_ENV}"
86+
# - uses: actions/checkout@v4
87+
# - uses: IronCoreLabs/rust-toolchain@v1
88+
# with:
89+
# toolchain: ${{ matrix.rust_version }}
90+
# - name: Install modules
91+
# run: yarn install --ignore-scripts
92+
# - name: Compile
93+
# run: yarn run compile
94+
# - name: Run tests
95+
# run: yarn run test

0 commit comments

Comments
 (0)