Skip to content

Commit b45646d

Browse files
committed
refactor: Schedule 수정 기능 리팩토링
1 parent f438acf commit b45646d

File tree

8 files changed

+26
-22
lines changed

8 files changed

+26
-22
lines changed

BE/error/src/main/java/com/example/demo/schedule/domain/ScheduleRepository.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,6 @@ public interface ScheduleRepository {
2222
void deleteById(Long eventId);
2323

2424
String findFilterColor(Long filterId);
25+
26+
String findFilterName(Long filterId);
2527
}

BE/error/src/main/java/com/example/demo/schedule/domain/model/ScheduleModel.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,26 +29,27 @@ public class ScheduleModel implements AbstractModel {
2929
private String eventInfo;
3030
private String eventPlace;
3131
private String scheduleType;
32-
private FilterEntity filter;
33-
private FilterModel filterModel;
34-
private MemberModel memberModel;
3532
private Long filterId;
3633
private Long memberId;
37-
private FilterRepository filterRepository;
3834
private ScheduleRepository scheduleRepository;
3935

4036
public ScheduleModel update(ScheduleModel requestModel) {
41-
4237
eventName = requestModel.getEventName();
4338
eventStartDate = requestModel.getEventStartDate();
4439
eventEndDate = requestModel.getEventEndDate();
4540
eventInfo = requestModel.getEventInfo();
4641
eventPlace = requestModel.getEventPlace();
47-
42+
filterId = this.getFilterId();
43+
memberId = this.getMemberId();
4844
return this;
4945
}
5046

5147
public String getFilterColor() {
5248
return scheduleRepository.findFilterColor(this.filterId);
5349
}
50+
51+
public String getFilterName() {
52+
return scheduleRepository.findFilterName(this.filterId);
53+
}
54+
5455
}

BE/error/src/main/java/com/example/demo/schedule/domain/model/converter/ScheduleRequestConverter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,13 @@ public ScheduleModel from(CreateScheduleRequest source) {
2828

2929
public ScheduleModel from(Long eventId, UpdateScheduleRequest source) {
3030
return ScheduleModel.builder()
31-
.eventId(source.getEventId())
31+
.eventId(eventId)
3232
.eventName(source.getEventName())
3333
.eventStartDate(source.getEventStartDate())
3434
.eventEndDate(source.getEventEndDate())
3535
.eventInfo(source.getEventInfo())
3636
.eventPlace(source.getEventPlace())
37+
//.filterId(source.getFilterId())
3738
.build();
3839
}
3940
}

BE/error/src/main/java/com/example/demo/schedule/domain/model/converter/ScheduleResponseConverter.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,9 @@ private AllPublicCalendarResponse toPublicCalendarResponse(ScheduleModel model)
5858
.eventPlace(model.getEventPlace())
5959
.eventInfo(model.getEventInfo())
6060
.scheduleType(model.getScheduleType())
61-
.filterId(model.getFilter() != null ? model.getFilter().getFilterId() : null)
62-
.filterName(model.getFilter() != null ? model.getFilter().getFilterName() : null)
63-
.filterColor(model.getFilter() != null ? model.getFilter().getFilterColor() : null)
61+
.filterId(model.getFilterId())
62+
.filterName(model.getFilterName())
63+
.filterColor(model.getFilterColor())
6464
.build();
6565
}
6666

@@ -81,9 +81,9 @@ private AllPrivateCalendarResponse toPrivateCalendarResponse(ScheduleModel model
8181
.eventPlace(model.getEventPlace())
8282
.eventInfo(model.getEventInfo())
8383
.scheduleType(model.getScheduleType())
84-
.filterId(model.getFilter() != null ? model.getFilter().getFilterId() : null)
85-
.filterName(model.getFilter() != null ? model.getFilter().getFilterName() : null)
86-
.filterColor(model.getFilter() != null ? model.getFilter().getFilterColor() : null)
84+
.filterId(model.getFilterId())
85+
.filterName(model.getFilterName())
86+
.filterColor(model.getFilterColor())
8787
.build();
8888
}
8989
}

BE/error/src/main/java/com/example/demo/schedule/infrastructure/ScheduleEntityConverter.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ public ScheduleEntity toEntity(ScheduleModel source) {
3434
.eventInfo(source.getEventInfo())
3535
.eventPlace(source.getEventPlace())
3636
.scheduleType(source.getScheduleType())
37-
//.filter(source.getFilter())
38-
//.filter(source.getFilterModel(source.getFilterId()))
3937
.filterId(source.getFilterId())
4038
.memberId(source.getMemberId())
4139
.build();

BE/error/src/main/java/com/example/demo/schedule/infrastructure/persistence/ScheduleEntity.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,7 @@ public class ScheduleEntity extends BaseEntity {
4343
@Column(nullable = false)
4444
private String scheduleType;
4545

46-
// @OneToOne(fetch = FetchType.LAZY)
47-
// @JoinColumn(name = "filter_id")
48-
// private FilterEntity filter;
4946

50-
// @OneToOne(fetch = FetchType.LAZY)
51-
// @JoinColumn(name = "member_id")
52-
// private MemberEntity member;
5347
@Column(nullable = false)
5448
private Long memberId;
5549

BE/error/src/main/java/com/example/demo/schedule/infrastructure/persistence/ScheduleJpaRepository.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,4 +78,13 @@ public String findFilterColor(Long filterId) {
7878
.findFirst() // 첫 번째 결과 가져오기
7979
.orElse(null);
8080
}
81+
82+
@Override
83+
public String findFilterName(Long filterId) {
84+
return em.createQuery("SELECT f.filterName FROM FilterEntity f WHERE f.filterId = :filterId", String.class)
85+
.setParameter("filterId", filterId)
86+
.getResultStream()
87+
.findFirst() // 첫 번째 결과 가져오기
88+
.orElse(null);
89+
}
8190
}

BE/error/src/main/java/com/example/demo/schedule/presentation/ScheduleController.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import java.util.List;
1414

1515

16-
1716
@RestController
1817
@RequiredArgsConstructor
1918
@RequestMapping("/api/calendar")

0 commit comments

Comments
 (0)