fix #24333: Search dialog should not offer some options when nothing is selected and a selection is needed

- disable radio buttons which need a selection, set mode to replace if search dialog is opened with empty collection (but not when a Filter is created)

git-svn-id: https://josm.openstreetmap.de/svn/trunk@19414 0c6e7542-c601-0410-84e7-c038aed88b3b

Author: GerdP

src/org/openstreetmap/josm/gui/dialogs/SearchDialog.java

@@ -28,6 +28,7 @@
 import javax.swing.text.Document;
 import javax.swing.text.JTextComponent;
 
+import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.Filter;
 import org.openstreetmap.josm.data.osm.search.SearchCompiler;
 import org.openstreetmap.josm.data.osm.search.SearchMode;
@@ -91,6 +92,20 @@ protected SearchDialog(SearchSetting initialValues, AutoCompComboBoxModel<Search
         hcbSearchString = new AutoCompComboBox<>(model);
         this.searchSettings = new SearchSetting(initialValues);
         setContent(buildPanel(options));
+
+        // See #24333
+        if (!(initialValues instanceof Filter)) {
+            DataSet data = MainApplication.getLayerManager().getActiveDataSet();
+            if (data != null && data.getSelected().isEmpty()) {
+                remove.setEnabled(false);
+                inSelection.setEnabled(false);
+                if (this.searchSettings.mode == SearchMode.in_selection
+                        || this.searchSettings.mode == SearchMode.remove) {
+                    this.searchSettings.mode = SearchMode.replace;
+                    replace.setSelected(true);
+                }
+            }
+        }
     }
 
     /**