fix PMD

git-svn-id: https://josm.openstreetmap.de/svn/trunk@19300 0c6e7542-c601-0410-84e7-c038aed88b3b

Author: stoecker

src/org/openstreetmap/josm/gui/preferences/display/ColorPreference.java

@@ -110,17 +110,14 @@ private static class ColorEntry {
          * @return a description of the color
          */
         public String getDisplay() {
-            switch (info.getCategory()) {
-                case NamedColorProperty.COLOR_CATEGORY_MAPPAINT:
-                    if (info.getSource() != null)
-                        return tr("Paint style {0}: {1}", tr(I18n.escape(info.getSource())), tr(info.getName()));
-                    // fall through
-                default:
-                    if (info.getSource() != null)
-                        return tr(I18n.escape(info.getSource())) + " - " + tr(I18n.escape(info.getName()));
-                    else
-                        return tr(I18n.escape(info.getName()));
+            if (info.getSource() != null) {
+                if (info.getCategory() == NamedColorProperty.COLOR_CATEGORY_MAPPAINT)
+                    return tr("Paint style {0}: {1}", tr(I18n.escape(info.getSource())), tr(info.getName()));
+                else
+                    return tr(I18n.escape(info.getSource())) + " - " + tr(I18n.escape(info.getName()));
             }
+            else
+                return tr(I18n.escape(info.getName()));
         }
 
         /**