Skip to content

Commit 3e43e20

Browse files
author
taylor.smock
committed
Fix test broken by dependency updates
EqualsVerifier did not like having two fields with the same name for an object. git-svn-id: https://josm.openstreetmap.de/svn/trunk@19294 0c6e7542-c601-0410-84e7-c038aed88b3b
1 parent b4688cb commit 3e43e20

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

src/org/openstreetmap/josm/command/AddPrimitivesCommand.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
*/
2525
public class AddPrimitivesCommand extends Command {
2626

27-
private List<PrimitiveData> data;
27+
private List<PrimitiveData> primitiveData;
2828
private Collection<PrimitiveData> toSelect;
2929
private List<PrimitiveData> preExistingData;
3030

@@ -55,9 +55,9 @@ public AddPrimitivesCommand(List<PrimitiveData> data, DataSet ds) {
5555

5656
private void init(List<PrimitiveData> data, List<PrimitiveData> toSelect) {
5757
CheckParameterUtil.ensureParameterNotNull(data, "data");
58-
this.data = new ArrayList<>(data);
58+
this.primitiveData = new ArrayList<>(data);
5959
if (toSelect == data) {
60-
this.toSelect = this.data;
60+
this.toSelect = this.primitiveData;
6161
} else if (toSelect != null) {
6262
this.toSelect = new ArrayList<>(toSelect);
6363
}
@@ -75,10 +75,10 @@ public boolean executeCommand() {
7575

7676
private void executeRealCommand(DataSet ds) {
7777
if (createdPrimitives == null) { // first time execution
78-
List<OsmPrimitive> newPrimitives = new ArrayList<>(data.size());
78+
List<OsmPrimitive> newPrimitives = new ArrayList<>(primitiveData.size());
7979
preExistingData = new ArrayList<>();
8080

81-
for (PrimitiveData pd : data) {
81+
for (PrimitiveData pd : primitiveData) {
8282
OsmPrimitive primitive = ds.getPrimitiveById(pd);
8383
boolean created = primitive == null;
8484
if (primitive == null) {
@@ -98,7 +98,7 @@ private void executeRealCommand(DataSet ds) {
9898
// Then load ways and relations
9999
for (int i = 0; i < newPrimitives.size(); i++) {
100100
if (!(newPrimitives.get(i) instanceof Node)) {
101-
newPrimitives.get(i).load(data.get(i));
101+
newPrimitives.get(i).load(primitiveData.get(i));
102102
}
103103
}
104104
newPrimitives.forEach(p -> p.setModified(true));
@@ -107,7 +107,7 @@ private void executeRealCommand(DataSet ds) {
107107
// a subsequent command (e.g. MoveCommand) cannot be redone.
108108
for (OsmPrimitive osm : createdPrimitives) {
109109
if (preExistingData.stream().anyMatch(pd -> pd.getPrimitiveId().equals(osm.getPrimitiveId()))) {
110-
Optional<PrimitiveData> o = data.stream()
110+
Optional<PrimitiveData> o = primitiveData.stream()
111111
.filter(pd -> pd.getPrimitiveId().equals(osm.getPrimitiveId())).findAny();
112112
o.ifPresent(osm::load);
113113
} else {
@@ -120,8 +120,8 @@ private void executeRealCommand(DataSet ds) {
120120
@Override public void undoCommand() {
121121
DataSet ds = getAffectedDataSet();
122122
if (createdPrimitives == null) {
123-
createdPrimitives = new ArrayList<>(data.size());
124-
for (PrimitiveData pd : data) {
123+
createdPrimitives = new ArrayList<>(primitiveData.size());
124+
for (PrimitiveData pd : primitiveData) {
125125
OsmPrimitive p = ds.getPrimitiveById(pd);
126126
createdPrimitives.add(p);
127127
}
@@ -146,7 +146,7 @@ private void executeRealCommand(DataSet ds) {
146146

147147
@Override
148148
public String getDescriptionText() {
149-
int size = data != null ? data.size() : createdPrimitives.size();
149+
int size = primitiveData != null ? primitiveData.size() : createdPrimitives.size();
150150
return trn("Added {0} object", "Added {0} objects", size, size);
151151
}
152152

@@ -161,14 +161,14 @@ public Collection<? extends OsmPrimitive> getParticipatingPrimitives() {
161161
if (createdPrimitives != null)
162162
return createdPrimitives;
163163

164-
return data.stream()
164+
return primitiveData.stream()
165165
.map(d -> Objects.requireNonNull(getAffectedDataSet().getPrimitiveById(d), () -> "No primitive found for " + d))
166166
.collect(Collectors.toSet());
167167
}
168168

169169
@Override
170170
public int hashCode() {
171-
return Objects.hash(super.hashCode(), data, toSelect, preExistingData, createdPrimitives);
171+
return Objects.hash(super.hashCode(), primitiveData, toSelect, preExistingData, createdPrimitives);
172172
}
173173

174174
@Override
@@ -177,7 +177,7 @@ public boolean equals(Object obj) {
177177
if (obj == null || getClass() != obj.getClass()) return false;
178178
if (!super.equals(obj)) return false;
179179
AddPrimitivesCommand that = (AddPrimitivesCommand) obj;
180-
return Objects.equals(data, that.data) &&
180+
return Objects.equals(primitiveData, that.primitiveData) &&
181181
Objects.equals(toSelect, that.toSelect) &&
182182
Objects.equals(preExistingData, that.preExistingData) &&
183183
Objects.equals(createdPrimitives, that.createdPrimitives);

0 commit comments

Comments
 (0)