Replace most calls for getNodes in VectorWay with direct calls to underlying list

This is primarily to avoid new unmodifiable collection instantiations where we
don't need a copy of the list. This significantly reduces the cost of the
post-processing merge ways step. Specifically, there is a 55% drop in the memory
cost, and 90% fewer CPU cycles.

git-svn-id: https://josm.openstreetmap.de/svn/trunk@19107 0c6e7542-c601-0410-84e7-c038aed88b3b

Author: taylor.smock

src/org/openstreetmap/josm/data/vector/VectorWay.java

@@ -56,12 +56,12 @@ public BBox getBBox() {
 
     @Override
     public int getNodesCount() {
-        return this.getNodes().size();
+        return this.nodes.size();
     }
 
     @Override
     public VectorNode getNode(int index) {
-        return this.getNodes().get(index);
+        return this.nodes.get(index);
     }
 
     @Override
@@ -82,12 +82,12 @@ public void setNodes(List<VectorNode> nodes) {
 
     @Override
     public List<Long> getNodeIds() {
-        return this.getNodes().stream().map(VectorNode::getId).collect(Collectors.toList());
+        return this.nodes.stream().map(VectorNode::getId).collect(Collectors.toList());
     }
 
     @Override
     public long getNodeId(int idx) {
-        return this.getNodes().get(idx).getId();
+        return this.nodes.get(idx).getId();
     }
 
     @Override