Rearranged the modules and split some modules into smaller parts

Author: JamesMessinger

best-practices.js renamed to best-practices/bugs.js

@@ -17,24 +17,12 @@ module.exports = {
     // make sure for-in loops have an if statement
     "guard-for-in": "error",
 
-    // require a capital letter for constructors
-    "new-cap": "error",
-
-    // disallow the omission of parentheses when invoking a constructor with no arguments
-    "new-parens": "error",
-
     // disallow use of the Array constructor
     "no-array-constructor": "error",
 
     // disallow use of bitwise operators
     "no-bitwise": "error",
 
-    // disallow use of arguments.caller or arguments.callee
-    "no-caller": "error",
-
-    // disallow the catch clause parameter name being the same as a variable in the outer scope
-    "no-catch-shadow": "warn",
-
     // disallow assignment in conditional expressions
     "no-cond-assign": "error",
 
@@ -68,9 +56,6 @@ module.exports = {
     // disallow comparisons to null without a type-checking operator
     "no-eq-null": "error",
 
-    // disallow use of eval()
-    "no-eval": "error",
-
     // disallow adding to native types
     "no-extend-native": "error",
 
@@ -92,9 +77,6 @@ module.exports = {
     // disallow overwriting functions written as function declarations
     "no-func-assign": "error",
 
-    // disallow use of eval()-like methods
-    "no-implied-eval": "error",
-
     // disallow function or variable declarations in nested blocks
     "no-inner-declarations": "error",
 
@@ -107,18 +89,12 @@ module.exports = {
     // disallow labels that share a name with a variable
     "no-label-var": "error",
 
-    // disallow use of labeled statements
-    "no-labels": "error",
-
     // disallow unnecessary nested blocks
     "no-lone-blocks": "warn",
 
     // disallow creation of functions within loops
     "no-loop-func": "warn",
 
-    // disallow use of multiline strings
-    "no-multi-str": "error",
-
     // disallow reassignments of native objects
     "no-native-reassign": "error",
 
@@ -146,36 +122,33 @@ module.exports = {
     // disallow use of octal escape sequences in string literals, such as var foo = "Copyright \050";
     "no-octal-escape": "error",
 
-    // disallow usage of __proto__ property
-    "no-proto": "error",
-
     // disallow declaring the same variable more then once
     "no-redeclare": "error",
 
-    // disallow use of javascript: urls.
-    "no-script-url": "error",
-
     // disallow comparisons where both sides are exactly the same
     "no-self-compare": "error",
 
-    // disallow use of comma operator
-    "no-sequences": "error",
-
     // disallow declaration of variables already declared in the outer scope
     "no-shadow": "warn",
 
-    // disallow shadowing of names such as arguments
-    "no-shadow-restricted-names": "error",
-
     // disallow sparse arrays
     "no-sparse-arrays": "error",
 
-    // disallow throwing non-Error objects
-    "no-throw-literal": "error",
-
     // disallow use of undeclared variables unless mentioned in a /*global */ block
     "no-undef": "error",
 
+    // disallow unreachable statements after a return, throw, continue, or break statement
+    "no-unreachable": "warn",
+
+    // disallow usage of expressions in statement position
+    "no-unused-expressions": [
+      "error",
+      {
+        allowShortCircuit: true,   // allow short-circuited expressions (e.g. foo && bar())
+        allowTernary: true,        // allow ternary expressions (e.g. foo ? bar() : baz())
+      },
+    ],
+
     // disallow declaration of variables that are not used in the code
     "no-unused-vars": [
       "error",
@@ -185,22 +158,6 @@ module.exports = {
       },
     ],
 
-    // disallow use of void operator
-    "no-void": "error",
-
-    // disallow use of the with statement
-    "no-with": "error",
-
-    // require assignment operator shorthand where possible
-    "operator-assignment": "error",
-
-    // Require the "use strict" pragma, either at the global level or function level,
-    // depending on whether CommonJS is being used or not
-    strict: [
-      "error",
-      "safe",
-    ],
-
     // disallow comparisons with the value NaN
     "use-isnan": "error",
 
@@ -210,8 +167,5 @@ module.exports = {
     // require immediate function invocation to be wrapped in parentheses
     "wrap-iife": "error",
 
-    // disallow Yoda conditions
-    yoda: "error",
-
   }
 };

best-practices/index.js

@@ -0,0 +1,11 @@
+"use strict";
+
+const bugs = require("./bugs");
+const security = require("./security");
+
+module.exports = {
+  extends: [
+    "modular/best-practices/bugs",
+    "modular/best-practices/security",
+  ],
+};

best-practices/security.js

@@ -0,0 +1,22 @@
+"use strict";
+
+module.exports = {
+  rules: {
+    // disallow use of eval()
+    "no-eval": "error",
+
+    // disallow use of eval()-like methods
+    "no-implied-eval": "error",
+
+    // disallow use of javascript: urls.
+    "no-script-url": "error",
+
+    // Require the "use strict" pragma, either at the global level or function level,
+    // depending on whether CommonJS is being used or not
+    strict: [
+      "error",
+      "safe",
+    ],
+
+  }
+};

browser.js renamed to browser/index.js

@@ -1,7 +1,7 @@
 "use strict";
 
 module.exports = {
-  extends: "modular/common-js",
+  extends: "modular/modules/cjs",
 
   env: {
     node: true,