Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for the code that parses and validates the config #4

Open
steinfletcher opened this issue Nov 7, 2019 · 0 comments
Open

Add test coverage for the code that parses and validates the config #4

steinfletcher opened this issue Nov 7, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@steinfletcher
Copy link
Contributor

steinfletcher commented Nov 7, 2019 •
edited
Loading

We want some coverage on the config parsing code. Currently the apitests define the config as structs, which is post validation in the code. We could either

  1. Unit test the file/config.go code
  2. Define the config as json in the apitest, which means apitests tests cover config parsing and validation

My preference is for 2 but I am open to suggestions.
@steinfletcher steinfletcher changed the title No coverage of the code that parses and validates the config Add test coverage for the code that parses and validates the config Nov 7, 2019
@steinfletcher steinfletcher added good first issue Good for newcomers help wanted Extra attention is needed labels Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steinfletcher