Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor events to use emitter pattern. #146

Open
JSideris opened this issue Jun 22, 2023 · 2 comments
Open

Refactor events to use emitter pattern. #146

JSideris opened this issue Jun 22, 2023 · 2 comments
Assignees
@JSideris
Labels
enhancement refactor

Comments

@JSideris
Copy link
Owner

GPT helped define this.

https://chat.openai.com/share/d26b2731-a6e2-4a7f-b9f4-b5d8fc751771

image image image image
@JSideris JSideris self-assigned this Jun 22, 2023
@JSideris JSideris mentioned this issue Dec 12, 2023
Open
9 tasks
@JSideris JSideris moved this to In Progress in DOThtml 6 Dec 12, 2023
@JSideris
Copy link
Owner Author

JSideris commented Feb 27, 2024 •
edited
Loading

We'll attach the event handlers inline per #177

@JSideris
Copy link
Owner Author

JSideris commented May 9, 2024

Update: #177 Won't work because we can no longer rely on component factories as this breaks the DI pattern. Component constructors can still accept arbitrary arguments. Maybe this problem is just something the user can handle on their own or through a third party extension. I'll take some time to think about how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JSideris JSideris

Labels
enhancement refactor
Projects
DOThtml 6
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JSideris