Update DatabaseFileLookupTest.java

Author: arfazca

src/test/java/org/jabref/logic/importer/DatabaseFileLookupTest.java

@@ -1,7 +1,9 @@
 package org.jabref.logic.importer;
 
-import java.util.Collection;
+import java.util.*;
 
+import javafx.collections.FXCollections;
+import javafx.collections.ObservableList;
 import org.jabref.logic.importer.fileformat.BibtexImporter;
 import org.jabref.logic.util.io.DatabaseFileLookup;
 import org.jabref.model.database.BibDatabase;
@@ -17,17 +19,11 @@
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.junit.jupiter.api.Assertions.fail;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.mockito.Mockito.mock;
-
-import org.junit.jupiter.api.io.TempDir;
-
-import java.io.IOException;
+import static org.mockito.Mockito.when;
 import java.nio.file.Files;
 import java.nio.file.Path;
-import java.nio.file.Paths;
-import java.util.Collections;
 
 class DatabaseFileLookupTest {
 
@@ -36,7 +32,16 @@ class DatabaseFileLookupTest {
 
     private BibEntry entry1;
     private BibEntry entry2;
+    private Path tempDir;
+    private Path txtFileDir;
+    private FilePreferences filePreferences;
+    private static DatabaseFileLookup fileLookup;
 
+    /**
+     * Sets up the test environment before each test case.
+     *
+     * @throws Exception if an error occurs during setup
+     */
     @BeforeEach
     void setUp() throws Exception {
         ParserResult result = new BibtexImporter(mock(ImportFormatPreferences.class, Answers.RETURNS_DEEP_STUBS),
@@ -45,8 +50,33 @@ void setUp() throws Exception {
         database = result.getDatabase();
         entries = database.getEntries();
 
+        tempDir = Files.createTempDirectory("testDir");
+        txtFileDir = tempDir.resolve("x.txt");
+
         entry1 = database.getEntryByCitationKey("entry1").get();
         entry2 = database.getEntryByCitationKey("entry2").get();
+
+        BibEntry entry3 = new BibEntry().withField(StandardField.FILE, txtFileDir.toAbsolutePath().toString());
+        BibEntry entry4 = new BibEntry().withField(StandardField.FILE, "");
+
+        List<BibEntry> entries = new ArrayList<>(Arrays.asList(entry1, entry2, entry3, entry4));
+        ObservableList<BibEntry> observableEntryList = FXCollections
+                .synchronizedObservableList(FXCollections.observableArrayList(entries));
+        BibDatabase databaseMock = mock(BibDatabase.class);
+        when(databaseMock.getEntries()).thenReturn(observableEntryList);
+
+        Files.write(txtFileDir, Collections.singleton("x.txt file contents for test"));
+
+        filePreferences = mock(FilePreferences.class);
+        when(filePreferences.getMainFileDirectory()).thenReturn(Optional.of(txtFileDir.toAbsolutePath()));
+
+        BibDatabaseContext databaseContext = mock(BibDatabaseContext.class);
+        when(databaseContext.getFileDirectories(filePreferences))
+                .thenReturn(Collections.singletonList(txtFileDir));
+        when(databaseContext.getDatabase()).thenReturn(databaseMock);
+        when(databaseContext.getDatabase().getEntries()).thenReturn(observableEntryList);
+        when(databaseContext.getDatabasePath()).thenReturn(Optional.of(txtFileDir.toAbsolutePath()));
+        fileLookup = new DatabaseFileLookup(databaseContext, filePreferences);
     }
 
     /**
@@ -61,50 +91,22 @@ void prerequisitesFulfilled() {
     }
 
     /**
-     * Tests the directory path functionality by creating a temporary file
-     * directory,
-     * creating a BibDatabaseContext with a BibDatabase containing two entries,
-     * setting the temporary directory as the default file directory in the
-     * preferences,
-     * and creating a DatabaseFileLookup instance.
-     *
-     * @param tempDir the temporary directory path
-     * @throws IOException if there is an error creating the temporary file
-     *                     directory
+     * x.txt should be found in the given directory.
      */
     @Test
-    void directoryPathTests(@TempDir Path tempDir) throws IOException {
-        Path txtFileDir = tempDir.resolve("x.txt"); // Create a temporary directory for testing
-
-        try {
-            Files.write(txtFileDir, Collections.singleton("x.txt file contents for test"));
-        } catch (IOException e) {
-            fail("Failed to create temporary file directory: " + e.getMessage());
-        }
-
-        // Create a BibDatabaseContext with a BibDatabase containing two entries
-        BibDatabase bibDatabase = new BibDatabase();
-        BibEntry entry1 = new BibEntry();
-        entry1.setField(StandardField.FILE, txtFileDir.toAbsolutePath().toString());
-        BibEntry entry2 = new BibEntry();
-        entry2.setField(StandardField.FILE, "");
-        bibDatabase.insertEntry(entry1);
-        bibDatabase.insertEntry(entry2);
-
-        BibDatabaseContext databaseContext = new BibDatabaseContext(bibDatabase);
-
-        // Set the temporary directory as the default file directory
-        // in the preferences and creating DatabaseFileLookup instance
-        FilePreferences filePreferences = new FilePreferences("", txtFileDir.toAbsolutePath().toString(), false, "", "",
-                false, false, null, Collections.emptySet(), false, null);
-        DatabaseFileLookup fileLookup = new DatabaseFileLookup(databaseContext, filePreferences);
-
-        // Tests
-        assertTrue(fileLookup.lookupDatabase(txtFileDir)); // x.txt should be found
-        assertFalse(fileLookup.lookupDatabase(tempDir.resolve("y.txt"))); // y.txt should not be found
+    void fileShouldBeFound() {
+        assertTrue(fileLookup.lookupDatabase(txtFileDir));
         assertEquals(filePreferences.getMainFileDirectory().orElse(Path.of("")).toString(),
                 txtFileDir.toAbsolutePath().toString());
         assertNotNull(fileLookup.getPathOfDatabase());
-        assertEquals("", fileLookup.getPathOfDatabase().toString());
+    }
+
+    /**
+     *
+     * y.txt should not be found in the any directory.
+     */
+    @Test
+    void fileShouldNotBeFound() {
+        assertFalse(fileLookup.lookupDatabase(tempDir.resolve("y.txt")));
     }
 }