Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

Investigate the possibility of setting jsx: true based on file extension #9

Closed
JamesHenry opened this issue Sep 25, 2018 · 3 comments
Closed

Comments

@JamesHenry
Copy link
Owner

Port of eslint/typescript-eslint-parser#399

@kaicataldo
Copy link
Collaborator

kaicataldo commented Oct 24, 2018

Is this something we'd still like to do here? I don't think this makes as much sense here as it did in typescript-eslint-parser. It doesn't look like the filename is referenced in the options, and it doesn't seem quite right to add it in for the sake of this, since you can already specify with the ecmaFeatures.jsx option.

My vote would be to close this issue and let consumers implement this if it's a behavior they'd like to leverage.

@kaicataldo
Copy link
Collaborator

For what it's worth, typescript-eslint-parser is adding this behavior: eslint/typescript-eslint-parser#543. I think it probably makes sense for Prettier to do the same?

@kaicataldo
Copy link
Collaborator

@JamesHenry Thoughts on closing this now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants