Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use string constants for Elasticsearch config properties #86

Closed
sjudeng opened this issue Feb 5, 2017 · 1 comment
Closed

Use string constants for Elasticsearch config properties #86

sjudeng opened this issue Feb 5, 2017 · 1 comment
Labels
index/elasticsearch kind/cleanup

Comments

@sjudeng
Copy link
Contributor

sjudeng commented Feb 5, 2017

Adding issue as requested in #79 (comment):

ElasticSearchIndex and ElasticSearchSetup use configuration properties as hardcoded strings. These properties should be collected and used as string constants.
@sjudeng
Copy link
Contributor Author

sjudeng commented Sep 19, 2017

This has been addressed.

@sjudeng sjudeng closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
index/elasticsearch kind/cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbrukman @sjudeng