Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate es to HTTP client and not TransportClient (on deprecation path) #92

Closed
amcp opened this issue Feb 6, 2017 · 5 comments
Closed

migrate es to HTTP client and not TransportClient (on deprecation path) #92

amcp opened this issue Feb 6, 2017 · 5 comments
Labels
index/elasticsearch
Milestone
Release v0.2.0

Comments

@amcp
Copy link

amcp commented Feb 6, 2017

At some point in the future, support for the Transport Client (native Java client) will be removed.
To mitigate, we need to use the HTTP API.
@sjudeng
Copy link
Contributor

sjudeng commented Feb 6, 2017

The current Java REST client in Elasticsearch 5.x is very low level. I'd recommend waiting until they release a higher level Java REST client before working on migration to avoid unnecessary work.

@amcp
Copy link
Author

amcp commented Feb 6, 2017

I agree it is extremely low level and would require major refactoring. We should wait for a higher level REST client. I just wanted to get ES lack of commitment to the transport client on our radar (so that we know to plan for it).

@krlohnes krlohnes mentioned this issue Mar 2, 2017
Merged
@pluradj
Copy link
Member

pluradj commented Mar 3, 2017

Related dev mailing list discussion https://groups.google.com/d/msg/janusgraph-dev/F-zfIsuiIoQ/q_R-kkhHDgAJ

krlohnes pushed a commit to krlohnes/janusgraph that referenced this issue Mar 7, 2017
Use Jest for Elasticsearch http JanusGraph#92
ad886c9 
Issue: JanusGraph#92

This adds http support to ElasticSearchIndex and removes support for the
Transport and Client modes. It also refactors the add/delete scripts to
use bindings since throwing a bunch of unique scripts at a Groovy
compiler isn't the best idea.

Signed-off-by: Keith Lohnes <[email protected]>
krlohnes pushed a commit to krlohnes/janusgraph that referenced this issue Mar 7, 2017
Use Jest for Elasticsearch http JanusGraph#92
d9a7df8 
Issue: JanusGraph#92

This adds http support to ElasticSearchIndex and removes support for the
Transport and Client modes. It also refactors the add/delete scripts to
use bindings since throwing a bunch of unique scripts at a Groovy
compiler isn't the best idea.

Signed-off-by: Keith Lohnes <[email protected]>
krlohnes pushed a commit to krlohnes/janusgraph that referenced this issue Mar 8, 2017
Use Jest for Elasticsearch http JanusGraph#92
32c0391 
Issue: JanusGraph#92

This adds http support to ElasticSearchIndex and removes support for the
Transport and Client modes. It also refactors the add/delete scripts to
use bindings since throwing a bunch of unique scripts at a Groovy
compiler isn't the best idea.

Signed-off-by: Keith Lohnes <[email protected]>
@krlohnes krlohnes mentioned this issue Mar 8, 2017
Closed
@sjudeng
Copy link
Contributor

sjudeng commented Apr 17, 2017

With merge of #79 JanusGraph now supports the low-level ES REST HTTP client. But keeping this issue open to track work on migrating to higher level HTTP client for ES (e.g. Jest or maybe eventually ES 6.x REST).

@sjudeng sjudeng mentioned this issue May 29, 2017
Merged
@sjudeng sjudeng added this to the Release v0.2.0 milestone Jun 17, 2017
@sjudeng
Copy link
Contributor

sjudeng commented Jun 17, 2017

With merge of #289 JanusGraph now only supports the ES REST HTTP client and the Transport client is no longer support.

@sjudeng sjudeng closed this as completed Jun 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
index/elasticsearch
Projects
None yet
Milestone
Release v0.2.0
Development

No branches or pull requests
4 participants
@amcp @mbrukman @pluradj @sjudeng