formatting and redundancy

Author: Jeremy5909

Diff for: src/camera.rs

@@ -3,7 +3,6 @@ use std::{f64::INFINITY, io::stdout};
 use rand::{thread_rng, Rng};
 
 use crate::{color::{write_color, Color}, hittable::{HitRecord, Hittable}, interval::Interval, ray::Ray, vec3::{unit_vector, Point3, Vec3}};
-use crate::material::Material;
 #[derive(Default)]
 pub struct Camera {
 	pub aspect_ratio: f64,
@@ -65,7 +64,7 @@ impl Camera {
 			return Color::default();
 		}
 		let mut rec = HitRecord::default();
-		if world.hit(r, Interval::from(0.001, INFINITY), &mut rec) {
+		if world.hit(r, Interval::new(0.001, INFINITY), &mut rec) {
 			let mut scattered = Ray::default();
 			let mut attenuation = Color::default();
 			if rec.mat.scatter(r, &rec, &mut attenuation, &mut scattered) {

Diff for: src/color.rs

@@ -13,7 +13,7 @@ pub fn write_color(out: &mut Stdout, pixel_color: Color) {
 	let g = linear_to_gamma(g);
 	let b = linear_to_gamma(b);
 
-	let intensity = Interval::from(0.0, 0.999);
+	let intensity = Interval::new(0.0, 0.999);
 	let rbyte = (256.0 * intensity.clamp(r)) as i32;
 	let gbyte = (256.0 * intensity.clamp(g)) as i32;
 	let bbyte = (256.0 * intensity.clamp(b)) as i32;

Diff for: src/hittable_list.rs

@@ -18,7 +18,7 @@ impl<'a> Hittable<'a> for HittableList<'a> {
 		let mut closest_so_far = ray_t.max;
 
 		for object in &self.objects {
-			if object.hit(r, Interval::from(ray_t.min, closest_so_far), &mut temp_rec) {
+			if object.hit(r, Interval::new(ray_t.min, closest_so_far), &mut temp_rec) {
 				hit_anything = true;
 				closest_so_far = temp_rec.clone().t;
 				*rec = temp_rec.clone();

Diff for: src/interval.rs

@@ -5,10 +5,7 @@ pub struct Interval {
 	pub max: f64
 }
 impl Interval {
-	pub fn new() -> Self {
-		Interval {min: NEG_INFINITY, max: INFINITY}
-	}
-	pub fn from(min: f64, max: f64) -> Self {
+	pub fn new(min: f64, max: f64) -> Self {
 		Interval {min, max}
 	}
 	pub fn size(&self) -> f64 {
@@ -23,4 +20,9 @@ impl Interval {
 	pub fn clamp(&self, x: f64) -> f64 {
 		x.clamp(self.min, self.max)
 	}
+}
+impl Default for Interval {
+	fn default() -> Self {
+		Interval {min: NEG_INFINITY, max: INFINITY}
+	}
 }

Diff for: src/material.rs

@@ -5,7 +5,7 @@ pub trait Material {
 }
 pub struct DefaultMaterial;
 impl Material for DefaultMaterial {
-	fn scatter(&self, r_in: &Ray, rec: &HitRecord, attenuation: &mut Color, scattered: &mut Ray) -> bool {
+	fn scatter(&self, _: &Ray, _: &HitRecord, _: &mut Color, _: &mut Ray) -> bool {
 		false
 	}
 }

Diff for: src/sphere.rs

@@ -36,7 +36,7 @@ impl<'a> Hittable<'a> for Sphere<'a> {
 		rec.p = r.at(rec.t);
 		let outward_normal = (rec.p - self.center) / self.radius;
 		rec.set_face_normal(r, &outward_normal);
-		rec.mat = self.mat.clone();
+		rec.mat = self.mat;
 
 		true
 	}

Diff for: src/vec3.rs

@@ -152,7 +152,6 @@ pub fn random_in_unit_sphere() -> Vec3 {
 	}
 }
 
-// Consider using lifetime
 pub fn random_unit_vector() -> Vec3 {
 	unit_vector(&random_in_unit_sphere())
 }