Skip to content

Commit f8d4135

Browse files
authored
fix: breakages in unused codepaths after recent refactors (bazel-contrib#2353)
* There is no such method `common_runfiles.add_runfiles`; use `add_targets()` instead. This only occurs when there are extra deps, which currently on Google-patches trigger. * The docs say that `BuiltinPyInfo` might be None, but that case is not handled here. This occurs in newer Bazel versions where the builtin PyInfo has been removed.
1 parent afecfd2 commit f8d4135

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

python/private/py_executable.bzl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ def _get_base_runfiles_for_binary(
454454
common_runfiles.files.add(implicit_pyc_source_files)
455455

456456
for dep in (ctx.attr.deps + extra_deps):
457-
if not (PyInfo in dep or BuiltinPyInfo in dep):
457+
if not (PyInfo in dep or (BuiltinPyInfo != None and BuiltinPyInfo in dep)):
458458
continue
459459
info = dep[PyInfo] if PyInfo in dep else dep[BuiltinPyInfo]
460460
common_runfiles.files.add(info.transitive_sources)
@@ -471,7 +471,7 @@ def _get_base_runfiles_for_binary(
471471

472472
common_runfiles.runfiles.append(collect_runfiles(ctx))
473473
if extra_deps:
474-
common_runfiles.add_runfiles(targets = extra_deps)
474+
common_runfiles.add_targets(extra_deps)
475475
common_runfiles.add(extra_common_runfiles)
476476

477477
common_runfiles = common_runfiles.build(ctx)

0 commit comments

Comments
 (0)