Cannot find builtin plugin JavaScript with 212 (2021.2 EAP) IDE dependency

[Undin]

The plugin shows error when I try to load a plugin project

Cannot create plugin from file (/Users/Arseniy.Pendryak/Programming/intellij-rust/deps/ideaIU-212.3116-EAP-CANDIDATE-SNAPSHOT/plugins/JavaScriptLanguage):
Invalid plugin descriptor 'plugin.xml': failed to resolve <xi:include>.
Not found document 'intellij.javascript.web.xml' referenced in <xi:include href="intellij.javascript.web.xml", xpointer="xpointer(/idea-plugin/*)"/>.
<xi:fallback> element is not provided. (at plugin.xml)

As a result, it's impossible to build plugins for 212 EAPs using gradle-intellij-plugin

Important details:

• gradle-intellij-plugin 0.7.3
• 212 IDEA Ultimate dependency (212.3116-EAP-CANDIDATE-SNAPSHOT)
• JavaScript plugin dependency

Test project can be found here

I suppose the root of the problem is a movement of META-INF/web-platform.xml to intellij.javascript.web.xml (i.e. to top level in the corresponding jar file).
As a result, com.jetbrains.plugin.structure.intellij.plugin.IdePluginManager#createPlugin(java.nio.file.Path, boolean, java.lang.String) fails to find intellij.javascript.web.xml. Not sure, it's an issue of the platform or org.jetbrains.intellij.plugins:structure-intellij dependency

Related to #608

[zolotov]

I suppose the root of the problem is a movement of META-INF/web-platform.xml to intellij.javascript.web.xml (i.e. to top level in the corresponding jar file).

I think all of them should be in the same jar

@serejke @hsz any ideas?

[Undin]

I think all of them should be in the same jar

They are in the same jar.
But there is a difference between 211 and 212. Although, I am not sure if it matters.

211	212

[zolotov]

I think it should be inside META-INF or to be referenced in some other way rather than just intellij.javascript.web.xml. I suppose it may not work in the IntelliJ production as well. @piotrtomiak what do you think?

[piotrtomiak]

@zolotov The change has been introduced by @develar in commit from 27.03.2021 and it's possible that there were some other changes to plugin classloading rules recently, which resulted in the aforementioned issue. I don't really know how to fix this, or why @develar moved the plugin descriptor out of META-INF, as intellij.javascript.web is a "virtual" module. In the build it's merged with JavaScript plugin and IMHO intellij.javascript.web.xml should be located in the same place as js-css.xml and other additional descriptors included from plugin.xml.

[zolotov]

My point is that it's an unlikely problem for the gradle-intellij-plugin and probably even the problem of the JavaScript plugin for IntelliJ. @piotrtomiak could you please investigate that together with @develar, or probably you know the better candidate to take this over?

[piotrtomiak]

@zolotov, agreed that this is most likely not a Gradle plugin problem. @develar, can you have a look?