Skip to content

Commit d6e8744

Browse files
authored
fix: coil load image with original size (#217)
* fix: coil load image use the original dimensions by default * fix: remove expo android ios folders and ignore it * chore: update dependecies and ci * chore: release 1.2.6 * chore: rm podfile.lock
1 parent 27b6f40 commit d6e8744

File tree

79 files changed

+28
-4738
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

79 files changed

+28
-4738
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ jobs:
154154
name: Android Test
155155
strategy:
156156
matrix:
157-
api-level: [24, 30, 31]
157+
api-level: [24, 31]
158158
target: [default]
159159
steps:
160160
- name: Checkout the code

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,17 @@
11

22

3+
## [1.2.6](https://github.com/JimmyDaddy/react-native-image-marker/compare/v1.1.8...v1.2.6) (2024-02-04)
4+
5+
6+
### Bug Fixes
7+
8+
* coil load image use the original dimensions by default ([fc29a6a](https://github.com/JimmyDaddy/react-native-image-marker/commit/fc29a6ac4c55e994863bd32d8b32e7414be0d378))
9+
10+
### Other Changes
11+
12+
* remove expo android ios folders and ignore it ([7cd0df2](https://github.com/JimmyDaddy/react-native-image-marker/commit/7cd0df272e516a18cacea6f4d8114ad14c36f769))
13+
14+
315
## [1.2.5](https://github.com/JimmyDaddy/react-native-image-marker/compare/v1.2.4...v1.2.5) (2024-01-26)
416

517

android/src/main/java/com/jimmydaddy/imagemarker/MarkerImageLoader.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import coil.decode.GifDecoder
1414
import coil.decode.ImageDecoderDecoder
1515
import coil.decode.SvgDecoder
1616
import coil.request.ImageRequest
17+
import coil.size.Size
1718
import com.facebook.react.bridge.ReactApplicationContext
1819
import com.jimmydaddy.imagemarker.base.Constants.IMAGE_MARKER_TAG
1920
import com.jimmydaddy.imagemarker.base.ErrorCode
@@ -56,6 +57,8 @@ class MarkerImageLoader(private val context: ReactApplicationContext, private va
5657
if (img.src != null && img.src.width > 0 && img.src.height > 0) {
5758
request = request.size(img.src.width, img.src.height)
5859
Log.d(IMAGE_MARKER_TAG, "src.width: " + img.src.width + " src.height: " + img.src.height)
60+
} else {
61+
request = request.size(Size.ORIGINAL)
5962
}
6063
imageLoader.enqueue(request.target (
6164
onStart = { _ ->

example/ios/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Podfile.lock

example/ios/ImageMarkerExample.xcodeproj/project.pbxproj

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -540,11 +540,7 @@
540540
"-DFOLLY_MOBILE=1",
541541
"-DFOLLY_USE_LIBCPP=1",
542542
);
543-
OTHER_LDFLAGS = (
544-
"$(inherited)",
545-
"-Wl",
546-
"-ld_classic",
547-
);
543+
OTHER_LDFLAGS = "$(inherited)";
548544
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
549545
SDKROOT = iphoneos;
550546
USE_HERMES = true;
@@ -611,11 +607,7 @@
611607
"-DFOLLY_MOBILE=1",
612608
"-DFOLLY_USE_LIBCPP=1",
613609
);
614-
OTHER_LDFLAGS = (
615-
"$(inherited)",
616-
"-Wl",
617-
"-ld_classic",
618-
);
610+
OTHER_LDFLAGS = "$(inherited)";
619611
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
620612
SDKROOT = iphoneos;
621613
USE_HERMES = true;

0 commit comments

Comments
 (0)