Skip to content

Commit 17121f2

Browse files
authored
Rollup merge of rust-lang#82740 - jyn514:proper-history, r=Mark-Simulacrum
Fix commit detected when using `download-rustc` On reflection on the issue in rust-lang#79540 (comment), I think the bug was actually using the `compiler/` filter, not using `--author=bors`. rust-lang@9a1d617 has no CI artifacts because it was merged as part of a rollup: ``` $ curl -I https://ci-artifacts.rust-lang.org/rustc-builds/96e843ce6ae42e0aa519ba45e148269de347fd84/rust-std-nightly-x86_64-unknown-linux-gnu.tar.xz HTTP/2 404 ``` So 9a1d617 is the correct commit to download, and that's what `--author=bors` does: $ git log --author=bors 4aec8a5 commit 9a1d617 Ideally it would look for "the most recent bors commit not followed by a change to `compiler/`", which would exclude things like documentation changes and avoid redownloading more than necessary, but - Redownloading isn't the end of the world, - That metric is hard to implement, and - Documentation-only or library-only changes are very rare anyway since they're usually rolled up with changes to the compiler. Helps with rust-lang#81930. r? `@Mark-Simulacrum`
2 parents c398871 + a705a58 commit 17121f2

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/bootstrap/bootstrap.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -647,9 +647,8 @@ def maybe_download_rustc(self):
647647
compiler = "{}/compiler/".format(top_level)
648648

649649
# Look for a version to compare to based on the current commit.
650-
# Ideally this would just use `merge-base`, but on beta and stable branches that wouldn't
651-
# come up with any commits, so hack it and use `author=bors` instead.
652-
merge_base = ["git", "log", "--author=bors", "--pretty=%H", "-n1", "--", compiler]
650+
# Only commits merged by bors will have CI artifacts.
651+
merge_base = ["git", "log", "--author=bors", "--pretty=%H", "-n1"]
653652
commit = subprocess.check_output(merge_base, universal_newlines=True).strip()
654653

655654
# Warn if there were changes to the compiler since the ancestor commit.

0 commit comments

Comments
 (0)