-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HalogenHooks recipes are broken on TryPureScript #279
Comments
I'm not well-versed in Halogen, but I think I can at least fix the trivially-fixable ones and mark the rest as broken. I'll plan on having a PR sometime this week. |
Yeah, one of the breaking changes in Halogen was dropping the |
Those two changes should fix everything except for any recipes that rely on event sources, as those have also changed in Halogen 6 (to become simpler!). |
I've started down the road of bumping PureScript to 0.14.3 and the package set to latest: #280. I'm not sure if there's a better alternative to resolving this, but so far the breakages haven't been too bad, and there might be trivial fixes for some of those I've marked as I can probably get to the rest sometime this week, if this would be a welcome change. If there's an alternative that's more minimal I could look into that instead. |
Thanks! Yes, this would be a desired change. Even if we only get some of this updated, that's better than none of it. This repo was designed to account for that possible situation. |
Resolved by #280 |
Recipe Name
Reason for Breakage / Steps to Fix
I think all the
*HalogenHooks
are currently broken on TryPureScript because of the mismatch of Halogen versions. Seems like a lot of them could be fixed by removingHH.HTML
as the first argument toComponent
(which now just takes four type parameters: https://pursuit.purescript.org/packages/purescript-halogen/6.1.2/docs/Halogen#t:Component), and removingJust
from some of the event handlers (Halogen.HTML.Event.onClick
for example now takesMouseEvent -> i
notMouseEvent -> Maybe i
: https://pursuit.purescript.org/packages/purescript-halogen/6.1.2/docs/Halogen.HTML.Events#v:onClick)The text was updated successfully, but these errors were encountered: