Skip to content

Commit 4709898

Browse files
authored
Tuples instead of vectors in tests (#193)
* Vector{Any} in tests * tuples instead of Vector{Any} * more tuples Co-authored-by: Jishnu Bhattacharya <[email protected]>
1 parent 56f3d38 commit 4709898

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

test/runtests.jl

+9-9
Original file line numberDiff line numberDiff line change
@@ -345,17 +345,17 @@ end
345345
@test -A_fill === Fill(-A_fill.value, 5)
346346

347347
# FillArray +/- FillArray should construct a new FillArray.
348-
test_addition_and_subtraction([A_fill, B_fill], [A_fill, B_fill], Fill)
348+
test_addition_and_subtraction((A_fill, B_fill), (A_fill, B_fill), Fill)
349349
test_addition_and_subtraction_dim_mismatch(A_fill, Fill(randn(rng), 5, 2))
350350

351351
# FillArray + Array (etc) should construct a new Array using `getindex`.
352352
A_dense, B_dense = randn(rng, 5), [5, 4, 3, 2, 1]
353-
test_addition_and_subtraction([A_fill, B_fill], [A_dense, B_dense], Array)
353+
test_addition_and_subtraction((A_fill, B_fill), (A_dense, B_dense), Array)
354354
test_addition_and_subtraction_dim_mismatch(A_fill, randn(rng, 5, 2))
355355

356356
# FillArray + StepLenRange / UnitRange (etc) should yield an AbstractRange.
357357
A_ur, B_ur = 1.0:5.0, 6:10
358-
test_addition_and_subtraction([A_fill, B_fill], (A_ur, B_ur), AbstractRange)
358+
test_addition_and_subtraction((A_fill, B_fill), (A_ur, B_ur), AbstractRange)
359359
test_addition_and_subtraction_dim_mismatch(A_fill, 1.0:6.0)
360360
test_addition_and_subtraction_dim_mismatch(A_fill, 5:10)
361361

@@ -369,19 +369,19 @@ end
369369
end
370370

371371
# Optimizations for Zeros and RectOrDiagonal{<:Any, <:AbstractFill}
372-
As_special_square = [
372+
As_special_square = (
373373
Zeros(3, 3), Zeros{Int}(4, 4),
374374
Eye(3), Eye{Int}(4), Eye(3, 3), Eye{Int}(4, 4),
375375
Diagonal(Fill(randn(rng, Float64), 3)), Diagonal(Fill(3, 4)),
376376
RectDiagonal(Fill(randn(rng, Float64), 3), 3, 3), RectDiagonal(Fill(3, 4), 4, 4)
377-
]
377+
)
378378
DiagonalAbstractFill{T} = Diagonal{T, <:AbstractFill{T, 1}}
379379
test_addition_and_subtraction(As_special_square, Bs_us, DiagonalAbstractFill)
380-
As_special_nonsquare = [
380+
As_special_nonsquare = (
381381
Zeros(3, 2), Zeros{Int}(3, 4),
382382
Eye(3, 2), Eye{Int}(3, 4),
383383
RectDiagonal(Fill(randn(rng, Float64), 2), 3, 2), RectDiagonal(Fill(3, 3), 3, 4)
384-
]
384+
)
385385
for A in As_special_nonsquare, B in Bs_us
386386
test_addition_and_subtraction_dim_mismatch(A, B)
387387
end
@@ -532,13 +532,13 @@ end
532532
@test +(z1) === z1
533533
@test -(z1) === z1
534534

535-
test_addition_and_subtraction([z1, z2], [z1, z2], Zeros)
535+
test_addition_and_subtraction((z1, z2), (z1, z2), Zeros)
536536
test_addition_and_subtraction_dim_mismatch(z1, Zeros{Float64}(4, 2))
537537
end
538538

539539
# `Zeros` +/- `Fill`s should yield `Fills`.
540540
fill1, fill2 = Fill(5.0, 4), Fill(5, 4)
541-
test_addition_and_subtraction([z1, z2], [fill1, fill2], Fill)
541+
test_addition_and_subtraction((z1, z2), (fill1, fill2), Fill)
542542
test_addition_and_subtraction_dim_mismatch(z1, Fill(5, 5))
543543

544544
X = randn(3, 5)

0 commit comments

Comments
 (0)