Generalize BandedLazyLayouts (#364)

* Generalize BandedLazyLayouts

* Update Project.toml

* Update LazyArraysBandedMatricesExt.jl

* default vcat resizedata!

* Update concattests.jl

Author: dlfivefifty

Project.toml

@@ -1,6 +1,6 @@
 name = "LazyArrays"
 uuid = "5078a376-72f3-5289-bfd5-ec5146d43c02"
-version = "2.5.1"
+version = "2.5.2"
 
 [deps]
 ArrayLayouts = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"

ext/LazyArraysBandedMatricesExt.jl

@@ -453,7 +453,7 @@ CachedArray(::Type{BandedMatrix}, matrix::AbstractMatrix{T}) where T = CachedArr
 bandwidths(B::CachedMatrix) = bandwidths(B.data)
 isbanded(B::CachedMatrix) = isbanded(B.data)
 
-cache_layout(::BandedLayouts, A::AbstractMatrix{T}) where T = CachedArray(BandedMatrix{T}(undef, (0,0), bandwidths(A)), A)
+cache_layout(::BandedLayouts, A::AbstractMatrix) = CachedArray(BandedMatrix{eltype(A)}(undef, (0,0), bandwidths(A)), A)
 
 function bandeddata(A::CachedMatrix)
     resizedata!(A, size(A)...)
@@ -537,12 +537,11 @@ bandeddata(R::ApplyMatrix{<:Any,typeof(rot180)}) = @view(bandeddata(arguments(R)
 # overload copy as overloading `mulreduce` requires `copyto!` overloads
 # Should probably be redesigned in a trait-based way, but hard to see how to do this
 
-const BandedLazyLayouts = Union{AbstractLazyBandedLayout, BandedColumns{LazyLayout}, BandedRows{LazyLayout},
-    TriangularLayout{UPLO,UNIT,BandedRows{LazyLayout}} where {UPLO,UNIT},
-    TriangularLayout{UPLO,UNIT,BandedColumns{LazyLayout}} where {UPLO,UNIT},
-    TriangularLayout{UPLO,UNIT,LazyBandedLayout} where {UPLO,UNIT},
-    SymTridiagonalLayout{LazyLayout}, BidiagonalLayout{LazyLayout}, TridiagonalLayout{LazyLayout},
-    SymmetricLayout{BandedColumns{LazyLayout}}, HermitianLayout{BandedColumns{LazyLayout}}}
+const BandedLazyLayouts = Union{AbstractLazyBandedLayout, BandedColumns{<:AbstractLazyLayout}, BandedRows{<:AbstractLazyLayout},
+    StructuredLayoutTypes{<:AbstractLazyBandedLayout},
+    StructuredLayoutTypes{<:BandedColumns{<:AbstractLazyLayout}},
+    StructuredLayoutTypes{<:BandedRows{<:AbstractLazyLayout}},
+    SymTridiagonalLayout{<:AbstractLazyLayout}, BidiagonalLayout{<:AbstractLazyLayout}, TridiagonalLayout{<:AbstractLazyLayout}}
 
 @inline islazy_layout(::BandedLazyLayouts) = Val(true)
 

src/padded.jl

@@ -116,6 +116,8 @@ function _vcat_resizedata!(::Union{AbstractPaddedLayout, DualLayout{<:PaddedRows
     B
 end
 
+_vcat_resizedata!(_, B, m...) = B # by default we can't resize
+
 resizedata!(B::Vcat, m...) = _vcat_resizedata!(MemoryLayout(B), B, m...)
 
 function ==(A::CachedVector{<:Any,<:Any,<:Zeros}, B::CachedVector{<:Any,<:Any,<:Zeros})

test/concattests.jl

@@ -657,6 +657,11 @@ import LazyArrays: MemoryLayout, DenseColumnMajor, materialize!, call, paddeddat
         A = Vcat([1 2 3], [4 5 6])
         @test A[2:-1:1,1:-1:1] == [4; 1 ;;]
     end
+
+    @testset "resizedata! for non-cached" begin
+        A = @inferred(Vcat(1:10, 1:20))
+        @test resizedata!(A, 3) ≡ A
+    end
 end
 
 end # module