Skip to content

Commit 2d44798

Browse files
authored
chore: add delay for docker tools, doc updates (#80)
Added slight delay in tools for docker commands to avoid a harmless but unnecessary error message. Corrected codecov badge in README. Stated a new file CONTRIBUTING.md with development specific notes.
1 parent 7323f20 commit 2d44798

File tree

3 files changed

+18
-1
lines changed

3 files changed

+18
-1
lines changed

CONTRIBUTING.md

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# Guidelines For Contributing
2+
3+
### Updating the code generator
4+
5+
The ["openapi-generator"](https://github.com/OpenAPITools/openapi-generator/) repository contains the code generator for Julia. For any changes that also need updates to the generated code, a PR needs to be made to the `openapi-generator` repo. Relevant files:
6+
- <https://github.com/OpenAPITools/openapi-generator/blob/master/.github/workflows/samples-julia.yaml>
7+
- <https://github.com/OpenAPITools/openapi-generator/tree/master/bin/configs/julia-client-petstore-new.yaml>
8+
- <https://github.com/OpenAPITools/openapi-generator/tree/master/bin/configs/julia-server-petstore-new.yaml>
9+
- <https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/julia>
10+
- <https://github.com/OpenAPITools/openapi-generator/tree/master/samples/server/petstore/julia>
11+
- <https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractJuliaCodegen.java>
12+
- <https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JuliaServerCodegen.java>
13+
- <https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/JuliaClientCodegen.java>
14+
- <https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/julia-client>
15+
- <https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/julia-server>
16+

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# OpenAPI
22

33
[![Build Status](https://github.com/JuliaComputing/OpenAPI.jl/workflows/CI/badge.svg)](https://github.com/JuliaComputing/OpenAPI.jl/actions?query=workflow%3ACI+branch%3Amain)
4-
[![codecov.io](http://codecov.io/github/JuliaComputing/OpenAPI.jl/coverage.svg?branch=main)](http://codecov.io/github/JuliaComputing/OpenAPI.jl?branch=main)
4+
[![codecov](https://codecov.io/gh/JuliaComputing/OpenAPI.jl/branch/main/graph/badge.svg?token=iZeFL7Js0l)](https://codecov.io/gh/JuliaComputing/OpenAPI.jl)
55

66
This is the Julia library needed along with code generated by the [OpenAPI generator](https://openapi-generator.tech/) to help define, produce and consume OpenAPI interfaces.
77

src/tools.jl

+1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ function _stop_docker(image_name::AbstractString, image_type::AbstractString; us
4545
return false
4646
end
4747

48+
sleep(5)
4849
container_id = strip(String(read(find_cmd)))
4950
if !isempty(container_id)
5051
rm_cmd = `$docker rm $container_id`

0 commit comments

Comments
 (0)