Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix depth and parent functions #37

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Fix depth and parent functions #37

merged 2 commits into from
Mar 11, 2025

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Mar 9, 2025

Fixes #36 and adds more tests.

Currently, depth starts at 0, but was it intended to start at 1?

@nhz2 nhz2 marked this pull request as ready for review March 9, 2025 03:51
@joshday
Copy link
Member

joshday commented Mar 11, 2025

If I'm remembering correctly, depth was used internally for parsing and printing. I didn't intend for public usage of it. That being said, if it's wrong I'd like to fix it! Thanks

@joshday joshday merged commit 93453d4 into JuliaComputing:main Mar 11, 2025
15 of 16 checks passed
@nhz2 nhz2 deleted the nz/depth-and-parent-tests branch March 11, 2025 17:37
@nhz2 nhz2 mentioned this pull request Mar 23, 2025
Open
@nhz2
Copy link
Contributor Author

nhz2 commented Mar 24, 2025

Thank you for reviewing and merging this. Could there be a new release of XML.jl with this fix to help with work on XLSX.jl?

@joshday
Copy link
Member

joshday commented Mar 24, 2025

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The depth function is hardcoded to return 1
2 participants
@nhz2 @joshday