New indexing traits names (#54)

Author: andreasnoack

REQUIRE

@@ -2,3 +2,4 @@ julia 0.5
 DiffBase 0.0.3
 ForwardDiff 0.3.4
 Calculus 0.2.0
+Compat 0.19.0

docs/src/limits.md

@@ -12,6 +12,6 @@ seen users run into ("target function" here refers to the function being differe
 
 - **Nested differentiation of closures is dangerous.** Differentiating closures is safe, and nested differentation is safe, but you might be vulnerable to a subtle bug if you try to do both. See [this ForwardDiff issue](https://github.com/JuliaDiff/ForwardDiff.jl/issues/83) for details. A fix is currently being planned for this problem.
 
-- **Array input types must obey `A<:AbstractArray` and `Base.linearindexing(::A) == Base.LinearFast()`.**
+- **Array input types must obey `A<:AbstractArray` and `Base.IndexStyle(::A) == Base.IndexLinear()`.**
 
 - **Array inputs that are being differentiated cannot be mutated**. This also applies to any "descendent" arrays that must be tracked (e.g. if `A` is an immutable input array, then `C = A * A` will also be immutable). If you try to perform `setindex!` on such arrays, an error will be thrown. In the future, this restriction might be lifted. Note that arrays explicitly constructed within the target function (e.g. via `ones`, `similar`, etc.) can be mutated, as well as output arrays used when taking the Jacobian of a function of the form `f!(output, input....).`

src/ReverseDiff.jl

@@ -4,6 +4,8 @@ module ReverseDiff
 
 using Base: RefValue
 
+using Compat
+
 using DiffBase
 using DiffBase: DiffResult
 

src/tracked.jl

@@ -68,7 +68,7 @@ immutable TrackedArray{V,D,N,VA,DA} <: AbstractArray{TrackedReal{V,D,TrackedArra
     deriv::DA
     tape::RawTape
     function TrackedArray(value::AbstractArray{V,N}, deriv::AbstractArray{D,N}, tape::RawTape)
-        @assert Base.linearindexing(value) === Base.LinearFast()
+        @assert IndexStyle(value) === IndexLinear()
         @assert size(value) === size(deriv)
         return new(value, deriv, tape)
     end
@@ -317,7 +317,7 @@ end
 
 Base.setindex!(t::TrackedArray, args...) = error("TrackedArrays do not support setindex!")
 
-Base.linearindexing(::TrackedArray) = Base.LinearFast()
+@compat Base.IndexStyle(::TrackedArray) = IndexLinear()
 
 Base.size(t::TrackedArray) = size(value(t))
 

test/TrackedTests.jl

@@ -2,6 +2,7 @@ module TrackedTests
 
 using ReverseDiff, Base.Test
 using ReverseDiff: TrackedReal, TrackedArray
+using Compat
 
 include(joinpath(dirname(@__FILE__), "utils.jl"))
 
@@ -703,7 +704,7 @@ instr = tp[1]
 @test instr.cache === nothing
 empty!(tp)
 
-@test Base.linearindexing(ta) === Base.LinearFast()
+@test IndexStyle(ta) === IndexLinear()
 
 @test Base.size(ta) === size(varr)