Update breaks autocomplete in jupyter-emacs org mode code cells

[MasonProtter]

I was using v0.4, but today I was trying to diagnose a problem so tried updating to the latest julia-emacs and it works fine in julia-mode, but when I open an org notebook that has jupyter-julia cells in it, completion no longer functions. Downgrading julia-emacs to v0.4 solves the issue for me.

[ronisbr]

The commit 759e8a8e572488eb7d8295bd0c3662b6c52fc3ec also broke Julia-ts-mode. Previously, I could, for example, press TAB at the beginning of the line to increase the indentation. Now, it shows the autocomplete window. Notice that I do not use TAB to autocomplete in doom emacs, but C-SPC.

If I am under a block string (""") in Julia-ts-mode, I can no longer add indentation steps inside the block string. Previously, it works by pressing TAB.

[ronisbr]

In my case, everything starts to work with this patch:

diff --git a/julia-mode.el b/julia-mode.el
index cc81343..95af6b4 100644
--- a/julia-mode.el
+++ b/julia-mode.el
@@ -918,9 +918,7 @@ buffer where the LaTeX symbol starts."
 (defun julia--company-indent-for-tab-command (arg)
   "Call `indent-for-tab-command' or `company-indent-or-complete-common'."
   (interactive "P")
-  (if company-mode
-      (company-indent-or-complete-common arg)
-    (indent-for-tab-command arg)))
+  (indent-for-tab-command arg))

 (with-eval-after-load 'company
   (define-key julia-mode-map [remap indent-for-tab-command]

I can also replace the latex symbols by typing C-SPC in Doom emacs.

Perhaps the problem is to assume that everybody is using TAB to perform completions?

[MasonProtter]

Thanks @ronisbr that fixes it for me.

---

Edit: no wait, sorry that does not actually fix for me :(

[MasonProtter]

Okay, I was able to bisect the issue to this commit: f359fd0 cc @non-Jedi

[ronisbr]

Hum, so maybe I am facing another issue. If so, I will open a new one here.

[non-Jedi]

Addressing the original filed issue: don't have much free time to spend right now, but I can at least direct you towards emacs-jupyter/jupyter#236. That PR probably might not fix the issue without some cleanup since #100 developed quite a bit afterward, but it should be a reasonable starting point. The problem @ronisbr is seeing is completely separate, and I'll address in a separate reply.

EDIT: Actually glancing at emacs-jupyter/jupyter#236, it probably works as is and just needs rebased. Not going to turn it from "Draft" into a full PR until somebody tests it though, and I don't have bandwidth to do so at the moment.

[non-Jedi]

The commit 759e8a8e572488eb7d8295bd0c3662b6c52fc3ec also broke Julia-ts-mode. Previously, I could, for example, press TAB at the beginning of the line to increase the indentation. Now, it shows the autocomplete window. Notice that I do not use TAB to autocomplete in doom emacs, but C-SPC.

If I am under a block string (""") in Julia-ts-mode, I can no longer add indentation steps inside the block string. Previously, it works by pressing TAB.

So the problem you're having is that you're using a capf backend (perhaps eglot) that can always come up with completion candidates. indent-for-tab-command first tries to indent before trying to complete (if tab-always-indent is set to 'complete); I thought this was the same thing company-indent-or-complete-common did, but it sounds like it goes the other way around and tries to complete and then falls back to indent. I think we should probably just remove this feature trying to be smart about how company users want completion to work.

[tpapp]

Thanks for the quick patch @non-Jedi, just merged #192.

@MasonProtter, @ronisbr: please check if the issue is fixed for you.

[MasonProtter]

EDIT: Actually glancing at nnicandro/emacs-jupyter#236, it probably works as is and just needs rebased. Not going to turn it from "Draft" into a full PR until somebody tests it though, and I don't have bandwidth to do so at the moment.

Just tried it out and autocomplete of LaTeX is still broken for me.

@MasonProtter, @ronisbr: please check if the issue is fixed for you.

Nope, that doesn't solve it for me.

[ronisbr]

Hi!

Thanks for the quick patch!

My problem is more-or-less solved because I cannot have the previous behavior.

If I use the latest commit with (setq julia-force-tab-complete t) (default), I can replace LaTeX symbols by pressing TAB. For example, "\alpha<TAB>" gives α. However, in this case, TAB always force indentation update. Hence, I am not able, for example, to increase the indentation by pressing TAB repeatedly as I could before.

If I set (setq julia-force-tab-complete nil), now I can increase the indentation by pressing TAB repeatedly. However, I lost the ability to replace LaTeX symbol by hitting TAB. In this case, I must use C-SPC, which is my default completion keystroke.

I am not saying we must revert to the old behavior. I am just saying that the behavior has changed and I am not certain if this is a bug or how the new system must work.

[non-Jedi]

For the problem with jupyter-emacs from the OP, I did some preliminary investigation and commented in emacs-jupyter/jupyter#236. This isn't really a julia-mode bug but a bug in the downstream dependency jupyter-emacs (caused by julia-mode making a breaking change). I'd recommend closing this issue and tracking the jupyter-emacs issue in either emacs-jupyter/jupyter#236 or a new issue against the repo.

For @ronisbr point above, I'm going to open a new issue for discussion.