Skip to content

Update compat for DataStructures 0.19, bump julia compat to 1.10#110

Merged
timholy merged 6 commits into
JuliaImages:masterfrom
Ickaser:ds-compat
Oct 9, 2025
Merged

Update compat for DataStructures 0.19, bump julia compat to 1.10#110
timholy merged 6 commits into
JuliaImages:masterfrom
Ickaser:ds-compat

Conversation

@Ickaser

@Ickaser Ickaser commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Replace peek/enqueue/dequeue with first/push/popfirst, rename IntDisjointSets (plural) to IntDisjointSet.

Depends on JuliaImages/ImageMorphology.jl#141. (Picked these two because they are in the Plots test dependency stack.)

@Ickaser

Ickaser commented Sep 23, 2025

Copy link
Copy Markdown
Contributor Author

The Julia 1.6 tests fail because Graphs.jl dropped julia 1.6 compat when it added DS 0.19 compat, so the environment can't be resolved. Is it worth dropping the 1.6 compat here? Could we just drop it from CI? Both?

@Ickaser

Ickaser commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

Can @juliohm or @timholy weigh in on removing Julia 1.6 from compat or CI for this? In the status quo DS is held back to 0.18 for all Plots testing, which is mildly annoying but not the worst thing.

@juliohm

juliohm commented Oct 4, 2025

Copy link
Copy Markdown
Member

@Ickaser I am all in for removing Julia v1.6 from CI, but I am not the maintainer of ImageSegmentation.jl.

If no one takes the lead in the following week, I will proceed with the merge.

Thank you for the updates.

@timholy

timholy commented Oct 8, 2025

Copy link
Copy Markdown
Member

To clarify, no one is the maintainer of ImageSegmentation.

I'm all in favor of bumping to 1.10 as the minimum. So the version of this package should be bumped to 1.10.0 at the same time.

@Ickaser

Ickaser commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

I went ahead and changed CI to run on lts , 1, and 'pre' (so currently on 1.10, 1.11, 1
12). If that is overkill I'm happy to scale it back.

Current test failures are due to #108, which is that some doctests are checking for the printing of anonymous functions; should I just remove those doctests altogether?

@Ickaser Ickaser changed the title Update compat for DataStructures 0.19 Update compat for DataStructures 0.19, bump julia compat to 1.10 Oct 8, 2025
@timholy

timholy commented Oct 8, 2025

Copy link
Copy Markdown
Member

I went ahead and changed CI to run on lts , 1, and 'pre' (so currently on 1.10, 1.11, 1.12)

That's fine. I'd also be fine with skipping pre.

should I just remove those doctests altogether?

Yeah, any that involve anonymous function printing could be eliminated.

@Ickaser

Ickaser commented Oct 8, 2025

Copy link
Copy Markdown
Contributor Author

That just needed a semicolon. Tests passing now, other than codecov/project which I do not fully understand.

@timholy timholy merged commit c6ba026 into JuliaImages:master Oct 9, 2025
10 of 11 checks passed
@timholy

timholy commented Oct 9, 2025

Copy link
Copy Markdown
Member

Thanks @Ickaser, nice work! JuliaRegistries/General#140013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants