Update compat for DataStructures 0.19, bump julia compat to 1.10#110
Conversation
|
The Julia 1.6 tests fail because Graphs.jl dropped julia 1.6 compat when it added DS 0.19 compat, so the environment can't be resolved. Is it worth dropping the 1.6 compat here? Could we just drop it from CI? Both? |
|
@Ickaser I am all in for removing Julia v1.6 from CI, but I am not the maintainer of ImageSegmentation.jl. If no one takes the lead in the following week, I will proceed with the merge. Thank you for the updates. |
|
To clarify, no one is the maintainer of ImageSegmentation. I'm all in favor of bumping to 1.10 as the minimum. So the version of this package should be bumped to 1.10.0 at the same time. |
|
I went ahead and changed CI to run on lts , 1, and 'pre' (so currently on 1.10, 1.11, 1 Current test failures are due to #108, which is that some doctests are checking for the printing of anonymous functions; should I just remove those doctests altogether? |
That's fine. I'd also be fine with skipping
Yeah, any that involve anonymous function printing could be eliminated. |
|
That just needed a semicolon. Tests passing now, other than |
|
Thanks @Ickaser, nice work! JuliaRegistries/General#140013 |
Replace peek/enqueue/dequeue with first/push/popfirst, rename
IntDisjointSets(plural) toIntDisjointSet.Depends on JuliaImages/ImageMorphology.jl#141. (Picked these two because they are in the Plots test dependency stack.)