-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Base.checked_add
and friends public
#57255
Comments
This comment has been minimized.
This comment has been minimized.
According to the literal definition of the Julia API, it would not be breaking to change Base's Automated tools (e.g. the REPL) will use the literal definition so we should make sure it's accurate. For example: help?> Base.checked_add
│ Warning
│
│ The following bindings may be internal; they may change or be
│ removed in future versions:
│
│ • Base.checked_add
Base.checked_add(x, y)
Calculates x+y, checking for overflow errors where applicable.
The overflow protection may impose a perceptible performance penalty. We should do this with all symbols exported into Base that are intended to be publicly accessible with |
This comment has been minimized.
This comment has been minimized.
In that case, the docstring of checked_add should be changed to not use |
should the docstrings of other functions like |
Actually, I agree with Lilith. I think it'd be better to keep the doc strings as-is, considering they've been this way for quite a long time, and just make the bindings |
No description provided.
The text was updated successfully, but these errors were encountered: