Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _copyto! as copyto_layout! #157

Open
dlfivefifty opened this issue Jul 26, 2023 · 2 comments
Open

Rename _copyto! as copyto_layout! #157

dlfivefifty opened this issue Jul 26, 2023 · 2 comments
Milestone

Comments

@dlfivefifty
Copy link
Member

I think a more descriptive name would be good here.

@dlfivefifty dlfivefifty added this to the v2.0 milestone Jul 26, 2023
@jishnub
Copy link
Member

jishnub commented Aug 2, 2023

Bikeshedding, but should this be layout_copyto! to be consistent with layout_getindex? Personally, I prefer this function_layout naming style, but renaming layout_getindex might require considerable changes across the ecosystem.

@dlfivefifty
Copy link
Member Author

I don't think its considerable changes to do layout_getindex -> getindex_layout since thats only ever called, never overloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants