Skip to content

Commit 2aea4ec

Browse files
eliascarvjuliohm
andauthored
Fix docs & Minor code design changes in SelectionRow (#149)
* Fix docs & Minor code design changes in SelectionRow * Remove unnecessary code * Add missing docs: SequentialTransform and ParallelTableTransform * Update docs/src/transforms/builtin.md Co-authored-by: Júlio Hoffimann <[email protected]>
1 parent 50e08e2 commit 2aea4ec

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ PairPlots = "43a3c2be-4208-490b-832a-a21dcd55d7da"
55
Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80"
66
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
77
TableTransforms = "0d432bfd-3ee1-4ac1-886a-39f05cc69a3e"
8-
TransformsAPI = "756644eb-7399-463e-a86e-97605fb648cd"
8+
TransformsBase = "28dd2a49-a57a-4bfb-84ca-1a49db9b96b8"
99

1010
[compat]
1111
Documenter = "0.27"

docs/make.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
using TableTransforms
2-
using TransformsAPI
2+
using TransformsBase
33
using Documenter
44

55
DocMeta.setdocmeta!(TableTransforms, :DocTestSetup, :(using TableTransforms); recursive=true)
@@ -8,7 +8,7 @@ DocMeta.setdocmeta!(TableTransforms, :DocTestSetup, :(using TableTransforms); re
88
ENV["GKSwstype"] = "100"
99

1010
makedocs(;
11-
modules=[TableTransforms, TransformsAPI],
11+
modules=[TableTransforms, TransformsBase],
1212
authors="Júlio Hoffimann <[email protected]> and contributors",
1313
repo="https://github.com/JuliaML/TableTransforms.jl/blob/{commit}{path}#{line}",
1414
sitename="TableTransforms.jl",

docs/src/index.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@ To revert a pipeline or single transform, use the [`apply`](@ref) and [`revert`]
115115
functions instead. The function [`isrevertible`](@ref) can be used to check if a transform is revertible.
116116

117117
```@docs
118-
TransformsAPI.apply
119-
TransformsAPI.revert
120-
TransformsAPI.isrevertible
118+
apply
119+
revert
120+
isrevertible
121121
```
122122

123123
To exemplify the use of these functions, let's create a table:
@@ -156,7 +156,7 @@ Finally, it is sometimes useful to [`reapply`](@ref) a transform that was
156156
cache from a previous [`apply`](@ref) call is used:
157157

158158
```@docs
159-
TransformsAPI.reapply
159+
reapply
160160
```
161161

162162
Consider the following example:

src/tableselection.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ Base.lastindex(row::SelectionRow) = row.ncols
103103
Base.getindex(row::SelectionRow, i::Int) = Tables.getcolumn(row, i)
104104

105105
# Tables.jl row interface
106-
Tables.columnnames(row::SelectionRow) = row.selection.names
106+
Tables.columnnames(row::SelectionRow) = Tables.columnnames(row.selection)
107107
Tables.getcolumn(row::SelectionRow, i::Int) =
108108
Tables.getcolumn(row.selection, i)[row.ind]
109109
Tables.getcolumn(row::SelectionRow, nm::Symbol) =

0 commit comments

Comments
 (0)