Skip to content

Commit 07bf40f

Browse files
committed
Change overflow tests to FD{Int8,1} to make the results easier to think about
1 parent 30aef4f commit 07bf40f

File tree

1 file changed

+23
-22
lines changed

1 file changed

+23
-22
lines changed

test/FixedDecimal.jl

+23-22
Original file line numberDiff line numberDiff line change
@@ -801,52 +801,53 @@ end
801801
end
802802

803803
@testset "overflow" begin
804+
T = FD{Int8, 1}
804805
@testset "addition" begin
805-
@test typemax(FD2) + eps(FD2) == typemin(FD2)
806-
@test typemin(FD2) + (-eps(FD2)) == typemax(FD2)
806+
@test typemax(T) + eps(T) == typemin(T)
807+
@test typemin(T) + (-eps(T)) == typemax(T)
807808
end
808809

809810
@testset "subtraction" begin
810-
@test typemin(FD2) - eps(FD2) == typemax(FD2)
811-
@test typemax(FD2) - (-eps(FD2)) == typemin(FD2)
811+
@test typemin(T) - eps(T) == typemax(T)
812+
@test typemax(T) - (-eps(T)) == typemin(T)
812813
end
813814

814815
@testset "multiplication" begin
815-
@test typemax(FD2) * 2 == FD2(-0.02)
816-
@test typemin(FD2) * 2 == FD2(0)
816+
@test typemax(T) * 2 == T(-0.2)
817+
@test typemin(T) * 2 == T(0)
817818
end
818819

819820
@testset "division" begin
820821
# TODO(PR): Is this the expected value?
821-
@test typemax(FD2) / FD2(0.5) == FD2(-0.02)
822-
@test typemin(FD2) / FD2(0.5) == FD2(0)
822+
@test typemax(T) / T(0.5) == FD2(-0.2)
823+
@test typemin(T) / T(0.5) == FD2(0)
823824
end
824825

825826
@testset "truncating division" begin
826827
# TODO(PR): Is this the expected value?
827-
@test typemax(FD2) ÷ FD2(0.5) == FD2(-0.16)
828-
@test typemin(FD2) ÷ FD2(0.5) == FD2(0.16)
829-
@test typemax(FD2) ÷ eps(FD2) == FD2(-1)
830-
@test typemin(FD2) ÷ eps(FD2) == FD2(0)
828+
@test typemax(T) ÷ T(0.5) == T(-0.6)
829+
@test typemin(T) ÷ T(0.5) == T(0.6)
830+
@test typemax(T) ÷ eps(T) == T(-1)
831+
@test typemin(T) ÷ eps(T) == T(0)
831832
end
832833

833834
@testset "fld / cld" begin
834835
# TODO(PR): Is this the expected value?
835-
@test fld(typemax(FD2), FD2(0.5)) == FD2(-0.16)
836-
@test fld(typemin(FD2), FD2(0.5)) == FD2(-0.84)
837-
@test fld(typemax(FD2), eps(FD2)) == FD2(-1)
838-
@test fld(typemin(FD2), eps(FD2)) == FD2(0)
836+
@test fld(typemax(T), T(0.5)) == T(-0.6)
837+
@test fld(typemin(T), T(0.5)) == T(-0.4)
838+
@test fld(typemax(T), eps(T)) == T(-1)
839+
@test fld(typemin(T), eps(T)) == T(0)
839840

840841
# TODO(PR): Is this the expected value?
841-
@test cld(typemax(FD2), FD2(0.5)) == FD2(0.84)
842-
@test cld(typemin(FD2), FD2(0.5)) == FD2(0.16)
843-
@test cld(typemax(FD2), eps(FD2)) == FD2(-1)
844-
@test cld(typemin(FD2), eps(FD2)) == FD2(0)
842+
@test cld(typemax(T), T(0.5)) == T(0.4)
843+
@test cld(typemin(T), T(0.5)) == T(0.6)
844+
@test cld(typemax(T), eps(T)) == T(-1)
845+
@test cld(typemin(T), eps(T)) == T(0)
845846
end
846847

847848
@testset "abs / neg" begin
848-
@test abs(typemin(FD2)) == typemin(FD2)
849-
@test -(typemin(FD2)) == typemin(FD2)
849+
@test abs(typemin(T)) == typemin(T)
850+
@test -(typemin(T)) == typemin(T)
850851
end
851852
end
852853

0 commit comments

Comments
 (0)